Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialization error happened for big servers #17

Open
2 tasks
mckaygerhard opened this issue Nov 8, 2021 · 0 comments
Open
2 tasks

serialization error happened for big servers #17

mckaygerhard opened this issue Nov 8, 2021 · 0 comments

Comments

@mckaygerhard
Copy link
Contributor

mckaygerhard commented Nov 8, 2021

i noted after many debug in my issues, now check that there's a temporally DB that stored dinamyc spawns..

it's the reading of info serialized right? well it seems there's a limit in serialization still not happpened in this mod of course... BUT IT WILL CRASH MY SERVER! i mean:

  1. this file it has only one line when i opened.. and as i know there's a limit over that line for files..
  2. also the way of reading the data is problematic due serialization limits of one line generate future errors

Taking in consideration that on each join of a player will read and wirte data in this file.. as urgent requirement for big amount of users:

  • in first time for now. we can use core.safe_file_write function event the direct file:write (will raise the compatibility from 0.4.16 to 0.4.17, but i can made a falback if there's the case)
  • usage oif line by line OR porting to json format, cos it seems the dynamicspawn.lua.ser uses direct lua arrays

Noted the usage of pairs in the reading of town and pregens, then:

  • For the second one is more difficult porting to use line by line (as in the names_per_ip) cos it seems the dynamicspawn.lua.ser uses direct lua arrays, that implicts a more complex coding..
  • But as i see here: , we need to made migration like minetest-mods/areas@a9c05f0 i asked and may i send pull to solve this!
@mckaygerhard mckaygerhard changed the title serialization error may happened in future due storage of dynamicspawn.lua.ser serialization error happened for big servers Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant