mkctr: add flag to save image/images to disk #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irbekrm
reviewed
Jan 29, 2025
mkctr.go
Outdated
| @@ -96,6 +98,7 @@ func main() { | |||
| ldflagsArg = flag.String("ldflags", "", "the --ldflags value to pass to go") | |||
| gotags = flag.String("gotags", "", "the --tags value to pass to go") | |||
| push = flag.Bool("push", false, "publish the image") | |||
| outPath = flag.String("out-path", "", "write single images to a tarball, or multi-platform images to a folder") | |||
There was a problem hiding this comment.
Do you need the single file path option? Can't we have a single --dst flag that takes a directory arg and writes either one or many files to that directory depending on whether it's a multi-arch or not?
There was a problem hiding this comment.
Feels like that would simplify the UX
This commit adds a new flag, --out-path which will allow the user to write the image to disk; if building a single image, e.g. with --target local, a tar is created at the out-path. if building a multi arch image, then a directorty is created with the images and oci manifest. Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
force-pushed
the
kradalby/image-to-file
branch
from
975889b to
db82727
Compare
irbekrm
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new flag, --out-path which will allow the user to write the image to disk;
if building a single image, e.g. with --target local, a tar is created at the out-path.
if building a multi arch image, then a directorty is
created with the images and oci manifest.