From 763b2bd15d4313edcf0ec2d891e3e08e220a6698 Mon Sep 17 00:00:00 2001 From: takahirom Date: Fri, 7 Jun 2024 09:33:39 +0900 Subject: [PATCH 1/7] Add rtl sample --- .../takahirom/roborazzi/sample/ComposeTest.kt | 31 ++++++++++++++++--- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt index 3050be170..257072979 100644 --- a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt +++ b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt @@ -69,7 +69,7 @@ class ComposeTest { composeTestRule.setContent { SampleComposableFunction() } - (0 until 3).forEach { _ -> + (0 until 10).forEach { _ -> composeTestRule .onNodeWithTag("AddBoxButton") .performClick() @@ -81,10 +81,10 @@ class ComposeTest { composeTestRule.activity.setContent { Column( modifier = Modifier - .clip(shape = RoundedCornerShape(16.dp)) - .background(Color.Gray) - .testTag("SettingsDialog") - .size(100.dp) + .clip(shape = RoundedCornerShape(16.dp)) + .background(Color.Gray) + .testTag("SettingsDialog") + .size(100.dp) ) { Text("Settings") Text("Dark theme") @@ -102,6 +102,27 @@ class ComposeTest { ) } + @Config(qualifiers = "+ar-rXB-ldrtl") + @Test + fun rtlCompose() { + composeTestRule.activity.setContent { + Column( + modifier = Modifier + .clip(shape = RoundedCornerShape(16.dp)) + .background(Color.Gray) + .testTag("SettingsDialog") + .size(100.dp) + ) { + Text("Settings") + Text("Dark theme") + } + } + + composeTestRule + .onNodeWithTag("SettingsDialog") + .captureRoboImage() + } + @Test @Config( sdk = [30], From 4604447ae4dbe8f82c52ac0aab7e63dba81b48e5 Mon Sep 17 00:00:00 2001 From: takahirom Date: Fri, 7 Jun 2024 09:34:35 +0900 Subject: [PATCH 2/7] Revert repeat count --- .../java/com/github/takahirom/roborazzi/sample/ComposeTest.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt index 257072979..d862b2801 100644 --- a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt +++ b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt @@ -69,7 +69,7 @@ class ComposeTest { composeTestRule.setContent { SampleComposableFunction() } - (0 until 10).forEach { _ -> + (0 until 3).forEach { _ -> composeTestRule .onNodeWithTag("AddBoxButton") .performClick() From 66969197777adee43e72332e862318214e03bcae Mon Sep 17 00:00:00 2001 From: takahirom Date: Fri, 7 Jun 2024 09:48:08 +0900 Subject: [PATCH 3/7] Change settings name --- .../com/github/takahirom/roborazzi/sample/ComposeTest.kt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt index d862b2801..0e9a743a1 100644 --- a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt +++ b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt @@ -83,7 +83,7 @@ class ComposeTest { modifier = Modifier .clip(shape = RoundedCornerShape(16.dp)) .background(Color.Gray) - .testTag("SettingsDialog") + .testTag("Settings") .size(100.dp) ) { Text("Settings") @@ -92,7 +92,7 @@ class ComposeTest { } composeTestRule - .onNodeWithTag("SettingsDialog") + .onNodeWithTag("Settings") .captureRoboImage( roborazziOptions = RoborazziOptions( recordOptions = RoborazziOptions.RecordOptions( @@ -110,7 +110,7 @@ class ComposeTest { modifier = Modifier .clip(shape = RoundedCornerShape(16.dp)) .background(Color.Gray) - .testTag("SettingsDialog") + .testTag("Settings") .size(100.dp) ) { Text("Settings") @@ -119,7 +119,7 @@ class ComposeTest { } composeTestRule - .onNodeWithTag("SettingsDialog") + .onNodeWithTag("Settings") .captureRoboImage() } From f94ef5cb498be81db39c04cfdd5771bee5e8f905 Mon Sep 17 00:00:00 2001 From: takahirom Date: Fri, 7 Jun 2024 10:35:57 +0900 Subject: [PATCH 4/7] Add isPseudoLocalesEnabled --- sample-android/build.gradle | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sample-android/build.gradle b/sample-android/build.gradle index 4a7f8e7bf..e88cb6347 100644 --- a/sample-android/build.gradle +++ b/sample-android/build.gradle @@ -18,6 +18,9 @@ android { } buildTypes { + debug { + isPseudoLocalesEnabled = true + } release { minifyEnabled false proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro' From 424e5f87f5ba11ed768dbd322212003f9d73d46e Mon Sep 17 00:00:00 2001 From: takahirom Date: Sat, 8 Jun 2024 13:45:42 +0900 Subject: [PATCH 5/7] Fix to use pseudoLocalesEnabled property --- sample-android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-android/build.gradle b/sample-android/build.gradle index e88cb6347..11dcdfebe 100644 --- a/sample-android/build.gradle +++ b/sample-android/build.gradle @@ -19,7 +19,7 @@ android { buildTypes { debug { - isPseudoLocalesEnabled = true + isPseudoLocalesEnabled true } release { minifyEnabled false From 424245e56f65bb05922137858d9be8ad5b592a28 Mon Sep 17 00:00:00 2001 From: takahirom Date: Sat, 8 Jun 2024 13:50:59 +0900 Subject: [PATCH 6/7] Use pseudoLocalesEnabled --- sample-android/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-android/build.gradle b/sample-android/build.gradle index 11dcdfebe..71084c46c 100644 --- a/sample-android/build.gradle +++ b/sample-android/build.gradle @@ -19,7 +19,7 @@ android { buildTypes { debug { - isPseudoLocalesEnabled true + pseudoLocalesEnabled true } release { minifyEnabled false From e2bfeae4e442b84948a3f8b7ec18e27d8e6823c0 Mon Sep 17 00:00:00 2001 From: takahirom Date: Sat, 8 Jun 2024 15:00:55 +0900 Subject: [PATCH 7/7] Add arabic texts --- sample-android/src/main/res/values-ar/strings.xml | 4 ++++ sample-android/src/main/res/values/strings.xml | 1 + .../java/com/github/takahirom/roborazzi/sample/ComposeTest.kt | 3 ++- 3 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 sample-android/src/main/res/values-ar/strings.xml diff --git a/sample-android/src/main/res/values-ar/strings.xml b/sample-android/src/main/res/values-ar/strings.xml new file mode 100644 index 000000000..3e166bd26 --- /dev/null +++ b/sample-android/src/main/res/values-ar/strings.xml @@ -0,0 +1,4 @@ + + + نص عينة + \ No newline at end of file diff --git a/sample-android/src/main/res/values/strings.xml b/sample-android/src/main/res/values/strings.xml index b931f2bde..607de0782 100644 --- a/sample-android/src/main/res/values/strings.xml +++ b/sample-android/src/main/res/values/strings.xml @@ -5,6 +5,7 @@ Second Fragment Next Previous + Sample Text Hello second fragment. Arg: %1$s \ No newline at end of file diff --git a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt index 0e9a743a1..8e30b8ff0 100644 --- a/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt +++ b/sample-android/src/test/java/com/github/takahirom/roborazzi/sample/ComposeTest.kt @@ -17,6 +17,7 @@ import androidx.compose.ui.Modifier import androidx.compose.ui.draw.clip import androidx.compose.ui.graphics.Color import androidx.compose.ui.platform.LocalConfiguration +import androidx.compose.ui.platform.LocalContext import androidx.compose.ui.platform.testTag import androidx.compose.ui.res.painterResource import androidx.compose.ui.semantics.CustomAccessibilityAction @@ -114,7 +115,7 @@ class ComposeTest { .size(100.dp) ) { Text("Settings") - Text("Dark theme") + Text(LocalContext.current.getString(R.string.rtl_text)) } }