Countdown not working well beyond 24 hours

[kumailSFS]

Count down working good under 24 hours but not when i put more than 86400 second (24 hours). Like when i put 86405 it will start from 5 seconds (00:00:05) instead of 86405 (24:00:05)

[griarman]

same issue

[muhammad-kumail]

@griarman Did you find a solution?

[griarman]

Yeah, I made some changes in the main file and patched them

patched file. Also i added an prop for enabling 24 hours

diff --git a/node_modules/react-native-countdown-component/index.js b/node_modules/react-native-countdown-component/index.js
index b546b82..882d630 100644
--- a/node_modules/react-native-countdown-component/index.js
+++ b/node_modules/react-native-countdown-component/index.js
@@ -37,6 +37,7 @@ class CountDown extends React.Component {
     onChange: PropTypes.func,
     onPress: PropTypes.func,
     onFinish: PropTypes.func,
+    showAllHours: PropTypes.bool,
   };
 
   state = {
@@ -45,6 +46,8 @@ class CountDown extends React.Component {
     wentBackgroundAt: null,
   };
 
+
+
   constructor(props) {
     super(props);
     this.timer = setInterval(this.updateTimer, 1000);
@@ -56,7 +59,6 @@ class CountDown extends React.Component {
 
   componentWillUnmount() {
     clearInterval(this.timer);
-    AppState.removeEventListener('change', this._handleAppStateChange);
   }
 
   componentDidUpdate(prevProps, prevState) {
@@ -95,7 +97,7 @@ class CountDown extends React.Component {
     return {
       seconds: until % 60,
       minutes: parseInt(until / 60, 10) % 60,
-      hours: parseInt(until / (60 * 60), 10) % 24,
+      hours: this.props.showAllHours ? parseInt(until / (60 * 60), 10) % 24 + parseInt(until / (60 * 60 * 24), 10) * 24 : parseInt(until / (60 * 60), 10) % 24,
       days: parseInt(until / (60 * 60 * 24), 10),
     };
   };
@@ -191,7 +193,7 @@ class CountDown extends React.Component {
   };
 
   renderCountDown = () => {
-    const {timeToShow, timeLabels, showSeparator} = this.props;
+    const {timeToShow, timeLabels, showSeparator, showAllHours} = this.props;
     const {until} = this.state;
     const {days, hours, minutes, seconds} = this.getTimeLeft();
     const newTime = sprintf('%02d:%02d:%02d:%02d', days, hours, minutes, seconds).split(':');
@@ -202,8 +204,8 @@ class CountDown extends React.Component {
         style={styles.timeCont}
         onPress={this.props.onPress}
       >
-        {timeToShow.includes('D') ? this.renderDoubleDigits(timeLabels.d, newTime[0]) : null}
-        {showSeparator && timeToShow.includes('D') && timeToShow.includes('H') ? this.renderSeparator() : null}
+        {timeToShow.includes('D') && !showAllHours ? this.renderDoubleDigits(timeLabels.d, newTime[0]) : null}
+        {showSeparator && timeToShow.includes('D') && !showAllHours && timeToShow.includes('H') ? this.renderSeparator() : null}
         {timeToShow.includes('H') ? this.renderDoubleDigits(timeLabels.h, newTime[1]) : null}
         {showSeparator && timeToShow.includes('H') && timeToShow.includes('M') ? this.renderSeparator() : null}
         {timeToShow.includes('M') ? this.renderDoubleDigits(timeLabels.m, newTime[2]) : null}
@@ -233,6 +235,7 @@ CountDown.defaultProps = {
   until: 0,
   size: 15,
   running: true,
+  showAllHours: false,
 };
 
 const styles = StyleSheet.create({

[griarman]

@muhammad-kumail