Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility/discoverability in Talon's default theme #53

Open
tmbb opened this issue Jun 13, 2017 · 3 comments
Open

Improve accessibility/discoverability in Talon's default theme #53

tmbb opened this issue Jun 13, 2017 · 3 comments

Comments

@tmbb
Copy link

tmbb commented Jun 13, 2017

Talon's default theme has switched from using action names ("Delete", "View", "Edit") to using icons.
Icons take up less space, but text is superior for discoverability and accessibility for visually impaired users.

I suggest adding a tooltip to action buttons and maybe add something for visually impaired users (ARIA attributes? I don't know much about accessibility or screen readers). This is of course not a priority right now, but something that should be solved in the future when things are more stable.

@dsnider
Copy link
Member

dsnider commented Jun 13, 2017

I agree about adding tooltips to the action buttons. I often prefer just links for resource actions, as done in ExAdmin, so we'll add some options here.

What's nice with Talon is you can change the action-related markup of the table_body.html.slim component within your project to something like below and it's used everywhere. In this case, I even fixed a current issue (#54) where the action links/buttons wrap by adding text-nowrap.

    td.text-right.index-actions.text-nowrap
      a.action-show href="#{Talon.Utils.talon_resource_path(resource, :show)}" Show
      a.action-edit href="#{Talon.Utils.talon_resource_path(resource, :edit)}" Edit
      a.delete-link href="#{Talon.Utils.talon_resource_path(resource, :delete)}" Delete

@tmbb
Copy link
Author

tmbb commented Jun 13, 2017

I often prefer just links for resource actions, as done in ExAdmin

Me too, but icons do save space. I'm on the fence about this one.

so we'll add some options here.

Given that's so easy to customize it yourself, I don't think adding options here would be necessary.
Maybe providing a different thee would be better. It would be cool if there was a mix task to install themes from a repo (github repo or something else). I don't think it's necessary to bundle all of that in talon's default installation.

@smpallen99
Copy link
Member

I don't think we should add options. I would like to proceed with icons and add aria labels for the text. Users are free to customize the generators if they want another option. I'm also ok with adding tool tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants