Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 1.2.1: Cannot find module 'app' #1

Open
thinkdj opened this issue Sep 1, 2016 · 8 comments
Open

Electron 1.2.1: Cannot find module 'app' #1

thinkdj opened this issue Sep 1, 2016 · 8 comments

Comments

@thinkdj
Copy link

thinkdj commented Sep 1, 2016

Constantly getting "Cannot find module 'app'" whenever require('electron-basic-updater') is called.

@thinkdj
Copy link
Author

thinkdj commented Sep 1, 2016

Because of the changes to Electron 1.2.1, this works:

    const Application = require('electron').app;
    const AppPath = Application.getAppPath() + '/';

@Slauta
Copy link
Contributor

Slauta commented Apr 11, 2017

Hi, i`m fixed this bug from pull-request #3

@daflav
Copy link

daflav commented Mar 15, 2018

Hello i have the same issue and i have const app = require('electron').app;
version electron : 1.7

@Slauta
Copy link
Contributor

Slauta commented Mar 15, 2018

@M4kaveli I gave pull request with fixing this problem 1 year ago, but @TamkeenLMS didn`t create new version in npm.
This is bad(

@daflav
Copy link

daflav commented Mar 15, 2018

@Slauta :( did you found another app like this?

@Slauta
Copy link
Contributor

Slauta commented Mar 15, 2018

@M4kaveli
Yes, i maked new а bike =)
But, i use electron-builder and electron-update now, it is very simply.

Docs

  1. Electron autoUpdate
  2. Electron builder

Config electron-updater for a private

  1. Github How to config electron-updater for a private GitHub Repo
  2. Gitlab Use gitlab.com private repository example

@daflav
Copy link

daflav commented Mar 15, 2018

Thanks for your help !
I also tried electron autoUpdate but i need one app that download on private url (no github) and download as zip extract.
Can i do this with autoUpdate ?

Best regards

@Slauta
Copy link
Contributor

Slauta commented Mar 15, 2018

@M4kaveli
You can build nsis app with electron builder (example: nsis for windows, dmg for Mac) and you can setup local server for updates (ex. https://github.com/zeit/hazel/blob/master/readme.md)

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants