Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic-node-adapter not working on node v14.18.0 #392

Closed
lane-s opened this issue Oct 22, 2021 · 2 comments
Closed

generic-node-adapter not working on node v14.18.0 #392

lane-s opened this issue Oct 22, 2021 · 2 comments

Comments

@lane-s
Copy link

lane-s commented Oct 22, 2021

It seems like at some point, the type of the data passed to the we socket "message" event callback changed from string to Buffer, which needs to be handled by the adapter (probably by simply doing (.toString data) when passing the data on to sente). Otherwise the invariant at taoensso.sente:208 is violated and no message can be received without crashing the server.

@ptaoussanis
Copy link
Member

ptaoussanis commented Feb 24, 2023

Is this report perhaps obsolete due to #398, #404?

I'm not too familiar with Sente+node, would be helpful if someone more familiar could take a look and comment!

@ptaoussanis
Copy link
Member

Closing as part of issue triage since I believe this may already be resolved on master.
Please feel free to re-open if this issue is still relevant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants