Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs: Add PARTITION to list of allowed hidden options for a scheduler profile. #118

Open
scblack321 opened this issue Jan 6, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@scblack321
Copy link
Collaborator

From e-mail sent by Richard Cardone on 12/20/2024

Steve and Alex,

It looks like Steve Clark can't remove this directive from the generated tapisjob.sh file:

      #SBATCH --partition

The fix seems to simply add a new enum value to SchedulerHiddenOptionEnum:

      PARTITION("PARTITION");

and then add another line of code to SystemsClient.java:

public static String getSchedulerHiddenOptionValue(SchedulerHiddenOptionEnum hiddenOptionEnum)
{
return switch (hiddenOptionEnum)
{
case MEM -> "--mem";
case PARTITION -> "--partition";
default -> "";
};
}

It's best for me not to make the change. Telling Steve Clark that we will be able to deliver a simple fix in early January will let him know that the solution is coming soon. Once delivered, he'll be able to add "PARTITION" to the SchedulerProfile hiddenOption, which will remove the partition directive from tapisjob.sh.

Rich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Staging
Development

No branches or pull requests

1 participant