New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout doesn't work for RouterCallImpl #15

Open

nurzhan-saktaganov opened this issue Jan 9, 2025 · 0 comments

Contributor

nurzhan-saktaganov commented Jan 9, 2025

Original: KaymeKaydex/go-vshard-router#74

Since we don't set a timeout for Tarantool.NewCallRequest using context.WithTimeout, a timeout for RouterCallImpl doesn't apply.

Also, we should inspect other functions for this bug.

UPD 19.12.2024: Timeout for RouterCallImpl will be fixed by KaymeKaydex/go-vshard-router#111

Check (add autotest), fix or add comment about how timeout works for these methods:

api.go
    - RouterCallImpl
    - RouterMapCallRWImpl
discovery.go
    - BucketDiscovery(aliases RouterRoute, BucketResolve)
    - DiscoveryAllBuckets
replicaset.go
    - BucketStat
    - ReplicaCall
    - CallAsync
    - BucketsCount
    - BucketForceCreate
sugar.go
    - Do
topology.go
    - AddInstance
    - AddReplicaset
    - RemoveReplicaset
vshard.go
    - NewRouter
    - ClusterBootstrap

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment