From a0738a335ea9a60a1f7329f0c1011dabd9f18d7e Mon Sep 17 00:00:00 2001 From: themilchenko Date: Thu, 3 Oct 2024 16:19:30 +0300 Subject: [PATCH] ci: overwrite tmpdir in mac integration tests The test `test_t3_instance_names_no_config` always fails because of very long path in tmpdir. This test requires socket path with fexed length, otherwise it can cause socket path buffer overflow. After the patch tmpdir was overwritten to the shorter one. Closes #931 --- .github/workflows/full-ci.yml | 4 +++- .github/workflows/tests.yml | 4 +++- magefile.go | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/full-ci.yml b/.github/workflows/full-ci.yml index 8a8cdf10d..b4be0087c 100644 --- a/.github/workflows/full-ci.yml +++ b/.github/workflows/full-ci.yml @@ -201,8 +201,10 @@ jobs: - name: Run unit tests run: mage unitfull + # We need to override TMPDIR here because of the very long path in macOS tests + # which causes a very long socket path error. - name: Integration tests - run: mage integrationfull + run: TMPDIR=/tmp mage integrationfull # Etcd can be still running after integration tests when: # 1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 9bea241e9..17a8fe1a3 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -197,8 +197,10 @@ jobs: - name: Unit tests run: mage unit + # We need to override TMPDIR here because of the very long path in macOS tests + # which causes a very long socket path error. - name: Run integration tests - run: mage integration + run: TMPDIR=/tmp mage integration # Etcd can be still running after integration tests when: # 1. pytest recieve SIGALRM (can be caused by pytest-timeout plugin) diff --git a/magefile.go b/magefile.go index f539c9a79..276d0fe48 100644 --- a/magefile.go +++ b/magefile.go @@ -415,7 +415,7 @@ func IntegrationFull() error { fmt.Println("Running all integration tests...") return sh.RunV(pythonExecutableName, "-m", "pytest", "-m", "not slow_ee and not notarantool", - "test/integration") + "test/integration", "-s") } // Run full set of integration tests, excluding docker tests.