Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: test_running_base_functionality() failed on CI #972

Open
patapenka-alexey opened this issue Oct 8, 2024 · 0 comments · May be fixed by #992
Open

tests: test_running_base_functionality() failed on CI #972

patapenka-alexey opened this issue Oct 8, 2024 · 0 comments · May be fixed by #992
Labels
1sp flaky test The issue describes the problem with the test being flaky teamE

Comments

@patapenka-alexey
Copy link
Contributor

patapenka-alexey commented Oct 8, 2024

There is currently failed/flaky CI test. We need to fix it.

                with open(os.path.join(run_dir, inst, 'tarantool.pid')) as f:
>                   assert pidByInstanceName[inst] != f.readline()
E                   AssertionError: assert '40972' != '40972'
E                    +  where '40972' = <built-in method readline of _io.TextIOWrapper object at 0x7fe31c598860>()
E                    +    where <built-in method readline of _io.TextIOWrapper object at 0x7fe31c598860> = <_io.TextIOWrapper name='/tmp/pytest-of-runner/pytest-0/test_running_base_functionalit1/small_cluster_app/var/run/storage-master/tarantool.pid' mode='r' encoding='UTF-8'>.readline

test/integration/running/test_running_cluster.py:113: AssertionError
----------------------------- Captured stdout call -----------------------------
 INSTANCE                           STATUS   PID    MODE  CONFIG               BOX      UPSTREAM 
 small_cluster_app:storage-master   RUNNING  40954  RO    startup_in_progress  loading  --       
 small_cluster_app:storage-replica  RUNNING  40955  RO    startup_in_progress  loading  --       

   • The Instance small_cluster_app:storage-master (PID = 41009) has been terminated.
   • The Instance small_cluster_app:storage-replica (PID = 41010) has been terminated.

=========================== short test summary info ============================
FAILED test/integration/running/test_running_cluster.py::test_running_base_functionality - AssertionError: assert '40972' != '40972'
 +  where '40972' = <built-in method readline of _io.TextIOWrapper object at 0x7fe31c598860>()
 +    where <built-in method readline of _io.TextIOWrapper object at 0x7fe31c598860> = <_io.TextIOWrapper name='/tmp/pytest-of-runner/pytest-0/test_running_base_functionalit1/small_cluster_app/var/run/storage-master/tarantool.pid' mode='r' encoding='UTF-8'>.readline
===== 1 failed, 583 passed, 76 skipped, 44 deselected in 858.55s (0:14:18) =====
Error: running "python3 -m pytest -m not slow and not slow_ee and not notarantool test/integration" failed with exit code 1
Error: Process completed with exit code 1.

logs_29212819413.zip

@patapenka-alexey patapenka-alexey added flaky test The issue describes the problem with the test being flaky python Pull requests that update Python code code health Improve code readability, simplify maintenance and so on labels Oct 8, 2024
@patapenka-alexey patapenka-alexey changed the title tests: test_running_base_functionality() integration test failed on CI tests: test_running_base_functionality() failed on CI Oct 8, 2024
@oleg-jukovec oleg-jukovec added 1sp teamE and removed python Pull requests that update Python code code health Improve code readability, simplify maintenance and so on labels Oct 9, 2024
themilchenko added a commit that referenced this issue Oct 21, 2024
The integration test `test_running_cluster::test_running_base_functionality`
fails sometimes with an failed assertion of the same PID after restart.

After the patch waiting for instances stop was added to make sure that
cluster is down before it will start again and will check for PID.

Closes #972
themilchenko added a commit that referenced this issue Oct 21, 2024
The integration test `test_running_cluster::test_running_base_functionality`
fails sometimes with an failed assertion of the same PID after restart.

After the patch waiting for instances stop was added to make sure that
cluster is down before it will start again and will check for PID.

Closes #972
themilchenko added a commit that referenced this issue Oct 22, 2024
The integration test `test_running_cluster::test_running_base_functionality`
fails sometimes with an failed assertion of the same PID after restart.

After the patch waiting for instances stop was added to make sure that
cluster is down before it will start again and will check for PID.

Closes #972
themilchenko added a commit that referenced this issue Oct 22, 2024
The integration test `test_running_cluster::test_running_base_functionality`
fails sometimes with an failed assertion of the same PID after restart.

After the patch waiting for instances stop was added to make sure that
cluster is down before it will start again and will check for PID.

Closes #972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1sp flaky test The issue describes the problem with the test being flaky teamE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants