Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Units in Carsus #245

Open
epassaro opened this issue Jun 2, 2021 · 2 comments
Open

Document Units in Carsus #245

epassaro opened this issue Jun 2, 2021 · 2 comments

Comments

@epassaro
Copy link
Member

epassaro commented Jun 2, 2021

From the upcoming docs:

In the recent years, much effort has been made to make Carsus easier to use and develop. A large piece of code was rewritten to avoid using an intermediate SQL database between the readers and the final atomic data.

This resulted in an simpler, faster and more maintainable Carsus codebase. But we lost some features in the process, being the most important one the tracking of physical quantities. Currently, we couldn’t solve the management of units in a sensible way.

We need to design and implement a new unit tracking system as soon as possible. In the meantime, should be enough to document the units used by the GFALL/CHIANTI/CMFGEN readers and the output module.

We agreed to document units until we design a new unit tracking system.

@Jay-sanjay
Copy link

hello sir can you tell exactly what I need to do here

@andrewfullard
Copy link
Contributor

See also #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants