GSoC Objective-1 Rewrite the TARDIS visualisation module using Panel #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
*beep* *bop* 4 F401 [*] `numpy` imported but unused
2 I001 [*] Import block is un-sorted or un-formatted
2 F821 [ ] Undefined name `GrotrianWidget`
1 E999 [ ] SyntaxError: Expected an expression
1 W292 [*] No newline at end of file
Complete output(might be large): .mailmap:1:38: E999 SyntaxError: Expected an expression
docs/analysing_tardis_outputs/visualization/how_to_generating_widgets.ipynb:cell 5:1:1: I001 [*] Import block is un-sorted or un-formatted
docs/analysing_tardis_outputs/visualization/how_to_generating_widgets.ipynb:cell 5:1:17: F401 [*] `panel` imported but unused
docs/analysing_tardis_outputs/visualization/how_to_generating_widgets.ipynb:cell 14:1:20: F821 Undefined name `LineInfoWidget`
docs/analysing_tardis_outputs/visualization/how_to_generating_widgets.ipynb:cell 19:1:23: F821 Undefined name `GrotrianWidget`
tardis/visualization/widgets/shell_info.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/widgets/shell_info.py:1:20: F401 [*] `tardis.run_tardis` imported but unused
tardis/visualization/widgets/shell_info.py:2:33: F401 [*] `tardis.io.atom_data.download_atom_data` imported but unused
tardis/visualization/widgets/shell_info.py:8:17: F401 [*] `numpy` imported but unused
tardis/visualization/widgets/shell_info.py:391:44: W292 [*] No newline at end of file
Found 10 errors.
[*] 7 fixable with the `--fix` option.
|
|
*beep* *bop* Hi, human. The Click here to see the build log. |
Comment on lines
-513
to
-520
| Parameters | ||
| ---------- | ||
| hdf_fpath : str | ||
| A valid path to a simulation HDF file (HDF file must be created | ||
| from a TARDIS Simulation object using :code:`to_hdf` method with | ||
| default arguments) | ||
|
|
||
| Returns |
Comment on lines
-229
to
-233
| It consists of four interlinked table widgets - shells table; element count, | ||
| ion count and level count tables - allowing to explore fractional abundances | ||
| all the way from elements, to ions, to levels by clicking on the rows of | ||
| tables. | ||
| """ |
There was a problem hiding this comment.
I aimed to make docstring more concise while maintaining clarity,.However, if the additional details are necessary for completeness, I’m open to refining the balance between brevity and informativeness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: 🚀 Feature | ☣️ Breaking Change | 📝 Documentation
🔹 This PR migrates the TARDIS visualization module to Panel, eliminating dependencies on qgrid, qgridnext, and IPython. This transition improves compatibility with Sphinx documentation while maintaining full interactivity.
🔹 The hierarchical dataset is now visualized as interlinked tables using SimulationShellInfo:
Selecting a row in the shell data table dynamically updates the element abundances table.
Further selection in the element abundances table updates additional tables showing ion count and level count.
🔹 The widget is fully operational in:
Jupyter Notebooks (inline execution)
📌 Resources
Full Video [watch here]
https://drive.google.com/drive/folders/1YX5T1tSHyy8AaJRWUM8WE__Y4BRUfObF?usp=sharing
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel