Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong breadcrumbs for posts without parents. #30

Open
aabouzaid opened this issue Jun 1, 2016 · 2 comments
Open

Wrong breadcrumbs for posts without parents. #30

aabouzaid opened this issue Jun 1, 2016 · 2 comments

Comments

@aabouzaid
Copy link

Hello,
The breadcrumbs of posts without parents always get "Docs" in breadcrumbs, and actually there is no page is called "Docs" at all (so it's returns 404).

How it does look like:
old_single_page_wedocs_theme_small

How it should be:
new_single_page_wedocs_theme_small

I believe this related to that part in "lib/custom.php" (and yeah, I'm using "develop" branch):

echo '<a href="' . $homeLink . '/' . $slug['slug'] . '/">' . $post_type->labels->singular_name . '</a>';
if ($showCurrent == 1) echo ' ' . $delimiter . ' ' . $before . get_the_title() . $after;

And should be replaced with:

if ($showCurrent == 1) echo ' ' . $before . get_the_title() . $after;

If I get it right and this is not intended, I will make a PR.
Thanks a lot.

@ufukayyildiz
Copy link

ufukayyildiz commented Jan 30, 2017

hi,

thank you for this. this is fixed my problem.

if you have any idea about this issue, can you share ? weDevsOfficial/wedocs-plugin#23

thank you in advance.

@ufukayyildiz
Copy link

hi again,

solution is here ; weDevsOfficial/wedocs-plugin#24

thanks to @HenchmenMedia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants