Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline configuration for the same test applied to multiple columns #37

Open
phpisciuneri opened this issue Mar 25, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@phpisciuneri
Copy link
Contributor

Currently, if I wanted to check for null values in each of the columns (age, occupation) of a table, the checks: section of the configuration file would contain something this:

- type: nullCheck
  column: age

- type: nullCheck
  column: occupation

Ideally, we should support a more streamlined config. Something like:

- type: nullCheck
  columns: age, occupation

We would need to decide how to handle optional parameters in the streamlined case. One option is that we do not support streamlining if any optional parameters are specified:

- type: nullCheck
  column: age
  threshold: 1%

- type: nullCheck
  column: occupation
  threshold: 5%

Another option would be to allow additional parameters to be streamlined and applied in the same order as the specified columns:

- type: nullCheck
  columns: age, occupation
  thresholds: 1%, 5%
@phpisciuneri phpisciuneri added the enhancement New feature or request label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant