Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack on-call status notifications are delayed longer than expected due to overzealous rate-limiting #4188

Open
mastercactapus opened this issue Dec 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mastercactapus
Copy link
Member

Describe the Bug:
When Slack on-call status notifications are triggered in quick succession, subsequent notifications can be significantly delayed (in this case, sent ~16 minutes after the triggering event). This behavior is unexpected and not clearly communicated, leading to confusion for users who receive updates well after changes occur.

Steps to Reproduce:

  1. Configure a GoAlert schedule and enable Slack on-call notifications.
  2. Trigger multiple on-call status changes/updates within a short period (e.g., adding and removing people from the on-call rotation in quick succession).
  3. Observe that after a couple of notifications, subsequent alerts are delayed before reaching Slack.

Expected Behavior:
Users should receive Slack on-call status notifications promptly after the on-call state changes, or at most with a minimal delay. If rate-limiting is enforced, it should be clearly documented or communicated within the UI to inform users that notifications are pending/delayed.

Observed Behavior:
A Slack notification scheduled at 11:25 AM was not delivered until 11:41 AM. The delay was attributed to rate-limiting logic that, while helpful in preventing spam for mediums like SMS/voice, appears to be overly aggressive and not clearly indicated for Slack notifications.

Application Version:
All versions as of v0.33.0

Additional Context:

  • Rate-limiting logic currently treats Slack notifications similarly to SMS/Voice, causing unintended delays for Slack updates.
  • Users have no direct visibility into pending or delayed messages, resulting in confusion. An indication or banner on the schedule page for delayed notifications would help.
  • Adjusting these rate limits or providing more transparency is desired to improve the user experience.
@mastercactapus mastercactapus added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant