Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: enhance transaction history pill count #1530

Open
brianp opened this issue Feb 14, 2025 · 0 comments
Open

feature: enhance transaction history pill count #1530

brianp opened this issue Feb 14, 2025 · 0 comments
Assignees
@shanimal08
Labels
a-ui enhancement New feature or request

Comments

@brianp
Copy link
Collaborator

brianp commented Feb 14, 2025

Describe the bug
Currently: The pill count, counts everything missed while the window is out of focus. The pill count stays in count with the "missed wins" animation.

Desire: Count everything since the user last opened the transaction history. It is entirely separate from missed wins, and doesn't matter if the window is in focus or not. The pill count should increase as long as the user hasn't opened the tx history.
@brianp brianp added a-ui enhancement New feature or request labels Feb 14, 2025
@shanimal08 shanimal08 mentioned this issue Feb 17, 2025
Merged
brianp pushed a commit that referenced this issue Feb 24, 2025
@shanimal08
feat(ui): reward pill update (#1531)
a9d147f 
Description
---

- added separate `rewardCount` counter for all wins (incl. missed)

Motivation and Context
---
- #1530

How Has This Been Tested?
---

- locally: 


https://github.com/user-attachments/assets/2218658f-0032-414b-812c-7a38e4288abc



What process can a PR reviewer use to test or verify this change?
---

- start mining 
- ensure counter show for all wins while in focus
- minimize
- ensure counter includes missed wins too
- open rewards
- counter should reset


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated the wallet interface to reflect rewards more clearly during
win events.
- Enhanced reward tracking to ensure win outcomes are accurately counted
and displayed.
	- Introduced a new method for managing reward counts in the state.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanimal08 shanimal08

Labels
a-ui enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianp @shanimal08