Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using of debugger corrupts the testmon database #114

Closed
tarpas opened this issue Jul 30, 2018 · 9 comments
Closed

using of debugger corrupts the testmon database #114

tarpas opened this issue Jul 30, 2018 · 9 comments

Comments

@tarpas
Copy link
Owner

tarpas commented Jul 30, 2018

from @max-imlian #90 (comment)
FYI I'm still having real issues with testmon, where it doesn't run tests despite both changes in the code and existing failures, even when I pass --tlf.

I love the goals of testmon, and it's performs so well in 90% of cases that it's become an essential part of my workflow. As a result, when it ignores tests that have changed, it's frustrating. I've found that --tlf often doesn't work, which is a shame as it was often a 'last resort' to testmon making a mistake in ignoring too many tests.

Is there any info I can supply that would help debug this? I'm happy to post anything.

Would there be any use of a 'Conservative' mode, where testmon would lean towards testing too much? A Type I error is far less costly than a Type II.

@tarpas
Copy link
Owner Author

tarpas commented Jul 30, 2018

As @blueyed noted, a reproducible test case would be the best. If we don't have that there is a couple of paths how to advance, but they are not quick. I'll try to comment here when I have the ideas formulated.

I don't think "conservative mode" is a way to go. We just need to fix the one (maybe 2) bugs.

What could be of value would be a functionality of "force-run" which would run selected tests and write the new coverage data.

@blueyed
Copy link
Contributor

blueyed commented Jul 30, 2018

I don't think "conservative mode" is a way to go. We just need to fix the one (maybe 2) bugs.

👍

What could be of value would be a functionality of "force-run" which would run selected tests and write the new coverage data.

Isn't that what --tlf should do in the first place?
But I guess what you mean to work around this is something like --testmon, but without deselecting anything.

In general I think some more reporting on what gets deselected why could be very useful.
Also maybe some dry-run mode where it would only report what would get run and what it knows about.

@max-sixty
Copy link

In general I think some more reporting on what gets deselected why could be very useful.
Also maybe some dry-run mode where it would only report what would get run and what it knows about.

👍

What could be of value would be a functionality of "force-run" which would run selected tests and write the new coverage data.

This would be a refined & better version of what I do now: git clean -xfd to clear caches + re-run. And it could also find any mistakes it's made by comparing its prior to the output (and maybe even compile a bug report!)

a reproducible test case would be the best. If we don't have that there is a couple of paths how to advance, but they are not quick. I'll try to comment here when I have the ideas formulated.

I'll try and spot some pattern for what could be causing the issues. Without being able to inspect what's going on (e.g. look at the DB), it's difficult to build a repro case from a bunch of failures in the project...

@tarpas
Copy link
Owner Author

tarpas commented Jul 31, 2018

Isn't that what --tlf should do in the first place?

No, --tlf is a testmon equivalent of --lf from the pytest itself.

--lf, --last-failed - to only re-run the failures.

So it reruns the failing tests, regardless if they are affected or not. (e.g. for debugging purposes - which is questionable because debuggers and testmon clash)

@max-imlian Are your using debugger and testmon at the same time? That might explain, your problems.

@max-sixty
Copy link

Are your using debugger and testmon at the same time?

Yes!

@tarpas tarpas changed the title intermittent missing of changes using of debugger corrupts the testmon database Aug 1, 2018
@tarpas
Copy link
Owner Author

tarpas commented Aug 1, 2018

@max-imlian That is not working, sorry.

See #97 (duplicate)

@tarpas tarpas closed this as completed Aug 1, 2018
@max-sixty
Copy link

Thanks @tarpas

To be clear, this includes the --pdb option?

@tarpas
Copy link
Owner Author

tarpas commented Aug 1, 2018 via email

@max-sixty
Copy link

OK, thanks, that explains a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants