Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Contract.wallet to Contract.account #374

Closed
marcelomorgado opened this issue May 2, 2019 · 5 comments · Fixed by #387
Closed

Rename Contract.wallet to Contract.account #374

marcelomorgado opened this issue May 2, 2019 · 5 comments · Fixed by #387
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@marcelomorgado
Copy link
Contributor

Or maybe setSenderAddress and getSenderAddress in case we want to set it to a contract-based account?

Getter/Setter should be renamed too.
Refs: #357 (comment)

@marcelomorgado marcelomorgado added the enhancement New feature or request label May 2, 2019
@marcelomorgado marcelomorgado added this to the 0.1.0 release milestone May 2, 2019
@marcelomorgado marcelomorgado added the question Further information is requested label May 2, 2019
@marcelomorgado
Copy link
Contributor Author

Good question. We can have these situations:

  • Same account as the signer and sender;
  • An account as sender and one as the signer;
  • An account as sender and many as the signers;

@pcowgill
Copy link
Member

pcowgill commented May 2, 2019

Good question. We can have these situations:

* Same account as the signer and sender;

* An account as sender and one as the signer;

* An account as sender and many as the signers;

Yep. Supporting and testing all of those situations is important (and maybe outside the scope of this issue based on its current name?)

@marcelomorgado
Copy link
Contributor Author

For short-term we can just rename from wallet to `account and then split this issue to continue the discussion of how should be the Contract API to support the situations above. Make sense?

@pcowgill
Copy link
Member

pcowgill commented May 2, 2019

For short-term we can just rename from wallet to `account and then split this issue to continue the discussion of how should be the Contract API to support the situations above. Make sense?

Yep, perfect!

@marcelomorgado
Copy link
Contributor Author

Discussion about API extracted to: #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants