Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more than strings and lists in from-dep's with-attributes #341

Open
bhearsum opened this issue Sep 5, 2023 · 0 comments
Open

support more than strings and lists in from-dep's with-attributes #341

bhearsum opened this issue Sep 5, 2023 · 0 comments

Comments

@bhearsum
Copy link
Contributor

bhearsum commented Sep 5, 2023

Right now, from-dep supports matching arbitrary values if they are part of a list of values, but only matching strings when directly defined. For example, you can do this:

from-deps:
  with-attributes:
    foo: [true]

But not:

from-deps:
  with-attributes:
    foo: true

We should probably be more lenient about the types of values we allow outside of the list, or more restrictive about what's allowed in the list. (I suggest that all basic types should be allowed in both places.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant