Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Remove client decorations (linux/wayland) #1046

Open
FabianLars opened this issue Jan 15, 2025 · 0 comments
Open

[request] Remove client decorations (linux/wayland) #1046

FabianLars opened this issue Jan 15, 2025 · 0 comments

Comments

@FabianLars
Copy link
Member

This is mostly about #979 / #977 tauri-apps/tauri#10702

From what i've heard so far the change caused more harm then good because now tao/tauri windows behave very non-wayland like.

First of all, the Titlebar buttons shouldn't have been a reason for this PR. If wayland doesn't show min/max buttons by default that's not our problem and if users want those buttons they should use the system settings to get them back.

Then the the more important problem, the 71 error code / resizing in general.

On wayland it's a very well known issue that app windows don't restore their state, but this is not our problem to fix if wayland doesn't want us to be able to do this.
I can't remember about Gnome, but KDE for example is working on this https://bugs.kde.org/show_bug.cgi?id=436318 etc

imho the better solution would have been to a) document wayland specific behavior as much as we can and b) :

  • Make set_size methods fail non-panicking if they had issues (didn't find mentions of this)
  • webkitgtk internal errors mentioned in #10702 either shouldn't be our concern, or we should finally add the mentioned workarounds (env vars) that also fix other issues.
  • moving and resizing with the native decorations not working should really have some other fix. i can't believe that this requires client decorations because this used to work fine without them for such a long time before.

Extra refs of issues people face after #979 (will add more over time)
https://discord.com/channels/616186924390023171/1328842890637607044
https://discord.com/channels/616186924390023171/1305624260479418451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant