-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[request] Add book cover images #3147
Comments
Hey @FabianLars I would love to implement this. Could you assign it to me ? |
Hey @FabianLars |
@Ncode-93 would you open a PR so we can see it live? for me, in this screenshot, the cover looks small, and I'd say the content could be laid out better. Like all in the same row, or title row + pic/details row. I think the current layout works for mobile, have to see it live And last suggestion to make sure it will scale nicely, try placing 2 more books, just as placeholder to visualize, then remove before merging, or don't commit at all... |
https://github.com/user-attachments/assets/8e836b2e-9ec5-4791-a66d-43d24141609a |
Hey @vasfvitor @FabianLars I've created a PR. Please acknowledge. |
Hey @vasfvitor @FabianLars I've created a new PR with suggested changes. |
@Ncode-93 fyi you could've pushed the changes to the first PR/branch, there would be no need to open a new one, but it's ok. Also when you open a PR it automatically notifies the team no need to tag, I'll take a loot at it, thanks again |
context https://v2.tauri.app/learn/#books
The author asked to include the book cover, and i think it'd be a valuable addition but i've failed to integrate it nicely. 🙃
I think this can be an easy-ish way to contribute to the docs, especially for those with astro experience so i thought i'd open an issue instead of refreshing my html/css knowledge.
The text was updated successfully, but these errors were encountered: