Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] Add book cover images #3147

Open
FabianLars opened this issue Jan 30, 2025 · 8 comments
Open

[request] Add book cover images #3147

FabianLars opened this issue Jan 30, 2025 · 8 comments
Assignees
Labels
enhancement Does it add or improve content? good first issue Is it good for beginners to take up?

Comments

@FabianLars
Copy link
Member

context https://v2.tauri.app/learn/#books

The author asked to include the book cover, and i think it'd be a valuable addition but i've failed to integrate it nicely. 🙃

I think this can be an easy-ish way to contribute to the docs, especially for those with astro experience so i thought i'd open an issue instead of refreshing my html/css knowledge.

@FabianLars FabianLars added enhancement Does it add or improve content? good first issue Is it good for beginners to take up? labels Jan 30, 2025
@Ncode-93
Copy link
Contributor

Hey @FabianLars I would love to implement this. Could you assign it to me ?

@Ncode-93
Copy link
Contributor

Ncode-93 commented Feb 2, 2025

Hey @FabianLars
Does this look fine ?

Image

@vasfvitor
Copy link
Contributor

vasfvitor commented Feb 2, 2025

@Ncode-93 would you open a PR so we can see it live? for me, in this screenshot, the cover looks small, and I'd say the content could be laid out better. Like all in the same row, or title row + pic/details row. I think the current layout works for mobile, have to see it live

And last suggestion to make sure it will scale nicely, try placing 2 more books, just as placeholder to visualize, then remove before merging, or don't commit at all...

@Ncode-93
Copy link
Contributor

Ncode-93 commented Feb 3, 2025

https://github.com/user-attachments/assets/8e836b2e-9ec5-4791-a66d-43d24141609a
Hey @vasfvitor as per your words, I have made changes, can you acknowledge this and post that I'll be raising PR. Or should I raise one rn ?

@vasfvitor
Copy link
Contributor

vasfvitor commented Feb 3, 2025

You can open a PR and we can go from there

Could you do more or less like the image below, it was made on paint.net just as an idea, it isn't a real mockup, with the text left aligned? The idea is to make most of the whitespace, but not too much condensed
Image

references:

https://elixir-lang.org/learning.html#books
Image

https://go.dev/learn/
Image

@Ncode-93
Copy link
Contributor

Ncode-93 commented Feb 6, 2025

Hey @vasfvitor @FabianLars I've created a PR. Please acknowledge.

#3159

@Ncode-93
Copy link
Contributor

Ncode-93 commented Feb 7, 2025

Hey @vasfvitor @FabianLars I've created a new PR with suggested changes.

#3161

@vasfvitor
Copy link
Contributor

@Ncode-93 fyi you could've pushed the changes to the first PR/branch, there would be no need to open a new one, but it's ok. Also when you open a PR it automatically notifies the team no need to tag, I'll take a loot at it, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does it add or improve content? good first issue Is it good for beginners to take up?
Projects
None yet
Development

No branches or pull requests

3 participants