From 11ec2227bc52e32abe8981a3cce5a56bcfe9c57f Mon Sep 17 00:00:00 2001 From: Ted Conbeer Date: Fri, 26 Jan 2024 12:22:21 -0700 Subject: [PATCH] fix: exit on error for _execute_query worker --- src/harlequin/app.py | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/src/harlequin/app.py b/src/harlequin/app.py index 17af2c9d..d480552c 100644 --- a/src/harlequin/app.py +++ b/src/harlequin/app.py @@ -382,19 +382,6 @@ async def _handle_worker_error(self, message: Worker.StateChanged) -> None: error=message.worker.error, ) self.data_catalog.database_tree.loading = False - elif ( - message.worker.name == "_execute_query" and message.worker.error is not None - ): - self.run_query_bar.set_responsive() - self.results_viewer.show_table() - header = getattr( - message.worker.error, "title", message.worker.error.__class__.__name__ - ) - self._push_error_modal( - title="Query Error", - header=header, - error=message.worker.error, - ) elif message.worker.name == "_connect" and message.worker.error is not None: title = getattr( message.worker.error, @@ -684,7 +671,7 @@ def _load_catalog_cache(self) -> None: @work( thread=True, exclusive=True, - exit_on_error=False, + exit_on_error=True, group="query_runners", description="Executing queries.", )