Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use withCredentials=false and xdomain could be removed #20

Open
wolframkriesing opened this issue Jul 17, 2015 · 1 comment
Open

Use withCredentials=false and xdomain could be removed #20

wolframkriesing opened this issue Jul 17, 2015 · 1 comment

Comments

@wolframkriesing
Copy link
Collaborator

like here https://github.com/wolframkriesing/es6-react-workshop/blob/master/src/_external-deps/http-get.js#L7

@shinenelson
Copy link

is this a "good first bug"?

as I see, one has to replace the usage of atomic with the node built-ins - http and url as is used in the linked file.

I know many things will probably break in its wake ( I hope there are tests to catch them ).

if that can be done successfully, can we remove atomicjs as a dependency and the use of the xdomain script in index.html?

is that all there is to get this done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants