You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue was reported to my team's .NET port of your library but I confirmed that it is an issue here as well.
The example on the README shows that the N-Gram code expects values of 0.416666 and 0.97222. However, different results are given when the code is actually ran. I am not sure if this is a bug in the code, or that the README comment is outdated/incorrect.
I created a unit test for the README example, and sure enough it fails:
java.lang.AssertionError:
Expected :0.416666
Actual :0.5833333134651184
This result (0.583) is the same that we get on the .NET side of things. As I am not an expert in these algorithms, I am unsure if this is a code bug or a need to update the README.
The text was updated successfully, but these errors were encountered:
... and I just noticed after posting this that 0.583333 ~= (1 - 0.416666). So this is an issue of difference vs similarity I guess. But I suppose we still need to confirm if the returned value from the library is incorrect, or if the comment is incorrect.
This issue was reported to my team's .NET port of your library but I confirmed that it is an issue here as well.
The example on the README shows that the N-Gram code expects values of 0.416666 and 0.97222. However, different results are given when the code is actually ran. I am not sure if this is a bug in the code, or that the README comment is outdated/incorrect.
I created a unit test for the README example, and sure enough it fails:
Results:
This result (0.583) is the same that we get on the .NET side of things. As I am not an expert in these algorithms, I am unsure if this is a code bug or a need to update the README.
The text was updated successfully, but these errors were encountered: