Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WPILib Preferences #133

Open
roshanr10 opened this issue Mar 15, 2019 · 9 comments
Open

Update WPILib Preferences #133

roshanr10 opened this issue Mar 15, 2019 · 9 comments
Assignees

Comments

@roshanr10
Copy link
Contributor

https://github.com/FRCteam4909/2019-Deep-Space/blob/ffb3913942e681edf8d4e876ea4639253799f2d5/.wpilib/wpilib_preferences.json#L4

@TechplexEngineer thoughts on this? I don't think we've had any issues with this and this configuration is never used to the best of my knowledge. We have had this conversation before, but I'd just like to clarify with you.

@TechplexEngineer
Copy link
Member

I think it should be updated. Not sure if it is strictly needed but would be good to do

@roshanr10
Copy link
Contributor Author

@Vultimate1 should be pretty straightforward, copy the corresponding JSON file mentioned above from the starter project in place of the current one and create a pull request to testing

@roshanr10 roshanr10 changed the title Update WPILib Preferences.? Update WPILib Preferences Mar 18, 2019
@roshanr10 roshanr10 added this to the Revere milestone Mar 18, 2019
@Vultimate1
Copy link
Contributor

The JSON file in the starter project is the same as the current file.

@roshanr10
Copy link
Contributor Author

roshanr10 commented Mar 19, 2019 via email

@roshanr10
Copy link
Contributor Author

This is what I see in the latest update, can you fix and push?

{
    "enableCppIntellisense": false,
    "currentLanguage": "java",
    "projectYear": "2019",
    "teamNumber": 4909
}

@Vultimate1
Copy link
Contributor

I opened the wpilib_preferences.json file from GitHub and I saw this:
{
"enableCppIntellisense": false,
"currentLanguage": "java",
"projectYear": "Beta2019",
"teamNumber": 4909
}
I also checked for updates, and there were none. Also, this code is on the Testing branch.

@Vultimate1
Copy link
Contributor

Which branch were you looking at when you saw the code with "projectYear": "Beta2019"?

@roshanr10
Copy link
Contributor Author

pretty sure it's the same in all of them

@TechplexEngineer
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants