From f885e69144a34eb929865f0893c36f2be26825bc Mon Sep 17 00:00:00 2001 From: Nils Weigel Date: Mon, 26 Sep 2022 09:07:57 +0200 Subject: [PATCH 1/2] [NSDPIMCORE-315] use a more recognizable thumbnail configuration name, automatically create thumbnail config during install --- Installer.php | 13 +++++++++++++ Resources/views/Slide/_slide-frontend.html.twig | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Installer.php b/Installer.php index 4a791d6..0f3b694 100644 --- a/Installer.php +++ b/Installer.php @@ -3,6 +3,7 @@ namespace Neusta\Pimcore\PresentationBundle; use Pimcore\Extension\Bundle\Installer\AbstractInstaller; +use Pimcore\Model\Asset\Image\Thumbnail; use Pimcore\Model\Document\DocType; class Installer extends AbstractInstaller @@ -10,6 +11,7 @@ class Installer extends AbstractInstaller public function install(): void { $this->installDocumentTypes(); + $this->installDumbThumbnailConfig(); } public function isInstalled(): bool @@ -54,4 +56,15 @@ private function installDocumentType(array $typeDefinition): void $model->setModificationDate($typeDefinition['modificationDate']); $model->save(); } + + private function installDumbThumbnailConfig(): void + { + if (Thumbnail\Config::exists('pimcore-presentation-bundle-background-image')) { + return; + } + + $thumbnailConfig = new Thumbnail\Config(); + $thumbnailConfig->setName('pimcore-presentation-bundle-background-image'); + $thumbnailConfig->save(); + } } diff --git a/Resources/views/Slide/_slide-frontend.html.twig b/Resources/views/Slide/_slide-frontend.html.twig index bbdc7ff..f7d5d7c 100644 --- a/Resources/views/Slide/_slide-frontend.html.twig +++ b/Resources/views/Slide/_slide-frontend.html.twig @@ -11,7 +11,7 @@ {% set showSouthRight = pimcore_areablock("south-right-content").getCount() > 0 %} {% if not pimcore_image("background-image").isEmpty() %} - {% set backgroundImageProperty = ' data-background-image="' ~ pimcore_image("background-image").thumbnail('dumb') ~ '"' %} + {% set backgroundImageProperty = ' data-background-image="' ~ pimcore_image("background-image").thumbnail('pimcore-presentation-bundle-background-image') ~ '"' %} {% else %} {% set backgroundImageProperty = '' %} {% endif %} From bafee49e61e30efdd06a0c5a0f94d876f87fc181 Mon Sep 17 00:00:00 2001 From: Nils Weigel Date: Mon, 26 Sep 2022 10:27:52 +0200 Subject: [PATCH 2/2] [NSDPIMCORE-315] fixed misleading method name --- Installer.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Installer.php b/Installer.php index 0f3b694..2ea2cf2 100644 --- a/Installer.php +++ b/Installer.php @@ -11,7 +11,7 @@ class Installer extends AbstractInstaller public function install(): void { $this->installDocumentTypes(); - $this->installDumbThumbnailConfig(); + $this->installThumbnailConfiguration(); } public function isInstalled(): bool @@ -57,7 +57,7 @@ private function installDocumentType(array $typeDefinition): void $model->save(); } - private function installDumbThumbnailConfig(): void + private function installThumbnailConfiguration(): void { if (Thumbnail\Config::exists('pimcore-presentation-bundle-background-image')) { return;