Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential bug: possible to create dangling landscape without associated group #438

Open
shrouxm opened this issue Apr 18, 2023 · 0 comments

Comments

@shrouxm
Copy link
Member

shrouxm commented Apr 18, 2023

Description

If this condition in the landscape creation code fails:

if creating and self.created_by:

then there will be a landscape with no associated group in the DB. I think with the current code logic this is not possible, but we could silently open ourselves up to this bug in the future if the logic changes such that self.created_by is not always non-null. This should probably throw an error so that the landscape does not get created in this case. But I am not sure about this.

Additional context

I don't think this is currently a problem, but just wanted to record this observation somewhere. Could be a good first issue to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants