Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debt: get the generated typescript types for the graphql schema to align with reality #549

Open
shrouxm opened this issue May 14, 2024 · 0 comments

Comments

@shrouxm
Copy link
Member

shrouxm commented May 14, 2024

Currently, optional fields in the graphql schema get translated to T | null | undefined, when as far as i know from the backend's perspective there's no difference between the two when sending data. So we should make sure that's the case, and then consolidate on a single choice of T | null or T | undefined in our graphql schema generation config.

Additional context

Hopefully, the only config change this requires is flipping this flag, but I'm not sure if that will create any migrations down the line or if that'll actually bring things into alignment with the backend.

@shrouxm shrouxm added this to LandPKS May 14, 2024
@github-project-automation github-project-automation bot moved this to Todo in LandPKS May 14, 2024
@shrouxm shrouxm added this to the LandPKS Backlog milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant