-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap all git commands automatically #85
Comments
This has been discussed before, see #69 for some background. I'd rather see something like |
I like that idea. I think this would help homesick follow the "do one thing well" principle better. However, I think some sort of Examples: I'm starting to realize, though, that we may run into issues when specifying a castle for the |
@nicolasmccurdy FWIW I was working on an exec command independently and have an implementation that's almost ready (without tests). If you like I could push it to my fork and perhaps we can work on this together. |
@JCook21 Sounds good, let me know and I can take a look at your implementation. By the way, how are you handling the UI for castle names at this point? (see my comment above) |
@nicolasmccurdy have a look at https://github.com/JCook21/homesick/tree/exec. Let me know what you think. :) |
@JCook21 That looks pretty good so far. I've commented on one of your commits, since I'd rather move discussion on the |
Closing this due to lack of discussion in almost 2 years. |
Homesick currently provides a command for every git command that can be executed through it manually. While this offers a convenient interface for some git commands, it means that we would have to add more homesick commands every time we wanted to use a git command that isn't provided. Instead, we could take the approach that tools like hub use and automatically provide all of git's interface by wrapping all of it with dynamic system calls. Homesick could intercept some git commands before shelling out to provide syntax sugar, and support the rest by only shelling out for compatibility.
Example
Advantages:
Disadvantages:
homesick git
, though.The text was updated successfully, but these errors were encountered: