Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling error on kube-vip bgp mode #633

Open
Qwiko opened this issue Jan 20, 2025 · 2 comments
Open

Spelling error on kube-vip bgp mode #633

Qwiko opened this issue Jan 20, 2025 · 2 comments

Comments

@Qwiko
Copy link

Qwiko commented Jan 20, 2025

When using kube-vip in bgp mode with multiple bgp peers using: kube_vip_bgp_peers variable it does not work due to this error.

Line here:

{% if _kube_vip_bgp_peers | length > 0 %}
        - name: bgppeers <- This variable here
          value: "{{ _kube_vip_bgp_peers | map(attribute='peer_address') | zip(_kube_vip_bgp_peers| map(attribute='peer_asn')) | map('join', ',') | join(':') }}"  # yamllint disable-line rule:line-length
{% else %}

This should be according to: https://kube-vip.io/docs/installation/flags/#environment-variables bgp_peers, not bgppeers.

@Qwiko
Copy link
Author

Qwiko commented Jan 20, 2025

It appears the line is joined incorrectly as well.

My example renders like this: 192.168.0.1,65001:192.168.11.1,65002
But should be the other way round: 192.168.0.1:65001,192.168.11.1:65002

Also this piece of code should not 'else' bgp_as. It should be before the bgp_peers section.

{% if _kube_vip_bgp_peers | length > 0 %}
        - name: bgppeers
          value: "{{ _kube_vip_bgp_peers | map(attribute='peer_address') | zip(_kube_vip_bgp_peers| map(attribute='peer_asn')) | map('join', ',') | join(':') }}"  # yamllint disable-line rule:line-length
{% else %}
{% if kube_vip_bgp_as is defined %}
        - name: bgp_as
          value: "{{ kube_vip_bgp_as }}"
{% endif %}

@timothystewart6
Copy link
Contributor

Thank you! I welcome a PR to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants