Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Quake feeds in start feed config #331

Open
melMass opened this issue Sep 18, 2023 · 1 comment
Open

[bug] Quake feeds in start feed config #331

melMass opened this issue Sep 18, 2023 · 1 comment
Labels
🐛 bug Something isn't working 🐣 good first issue Good for newcomers

Comments

@melMass
Copy link
Member

melMass commented Sep 18, 2023

Describe the bug

Small regression from #325
Since for now we strip the emojis in the dropdown for the startfeed config (TLDR on windows they don't render properly, also on some linux distros, only mac as full native support for them so we use twemoji but I couldn't find how to make it work inside the react select last time I tried)

image

Expected behavior

Either:

  • make twemoji work in react select
  • rename the quake feeds with for instance the shorthand for the countries (MAR for Morocco)
  • Ignore it

Platform and versions

Not relevant

Console output

No response

Additional context

No response

@melMass melMass added 🐛 bug Something isn't working 🧹 needs triage The issue/PR was not yet reviewed by a maintainer 🐣 good first issue Good for newcomers and removed 🧹 needs triage The issue/PR was not yet reviewed by a maintainer labels Sep 18, 2023
@Zir0h
Copy link
Contributor

Zir0h commented Sep 18, 2023

+1 for option 2, might also be better in a usability context?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🐣 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants