Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedFrom(array<Block>) by default ignores signature verification #6

Open
telamon opened this issue Jul 28, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@telamon
Copy link
Owner

telamon commented Jul 28, 2024

this._index(false, sigKeyMap)

This should be an option feedFrom(source, noVerify=false)

Scenarios where signature verification should be bypassed is when loading feeds from a trusted location
like a blockstore where only the previously verified blocks are stored.

But in all normal scenarios this would be major pitfall, signatures should always be verified whenever a new
feed is instanced.

@telamon telamon added the bug Something isn't working label Jul 28, 2024
@telamon
Copy link
Owner Author

telamon commented Jul 28, 2024

Something got borked when we started including public keys of authors into blocks.
Before we used the presence of a key in Feed.keys to track the the verified status of a block.

Just a memo to myself;
As a user i don't want to accidentally read unverified data, all instances of Feed are always verified.
As a block-store i don't want to re-verify previously persisted blocks in a trusted store, i need to bypass verification in feedFrom()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant