Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Support for Firestore #2

Open
ilyaigpetrov opened this issue Jul 27, 2018 · 2 comments
Open

Feature: Add Support for Firestore #2

ilyaigpetrov opened this issue Jul 27, 2018 · 2 comments
Labels

Comments

@ilyaigpetrov
Copy link

It's quiet easy but I don't feel my code is robust yet: https://github.com/ilyaigpetrov/telegraf-session-firebase
Either I should read more of documentation and recheck everything or someone more experienced should add this feature.

@MicxSamonte
Copy link

Bump on this @dotcypress

@KnorpelSenf
Copy link

KnorpelSenf commented Mar 29, 2020

As firestore and firebase realtime database are two distinct storage solutions, I believe it makes sense to provide individual middlewares for them. I created telegraf-session-firestore for this purpose. It is based on both this repository and @ilyaigpetrov's fork, but fixes a minor issues with the latter in case of a non-existing document (edit: the problem did not occur in real-world applications, your code was good). Also, I added TypeScript typings.
If you think these two middlewares should be unified, we can see how we can merge them. Otherwise this issue may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants