Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support for OpenShift #241

Open
hishamanver opened this issue Sep 13, 2024 · 5 comments
Open

[Feature Request] Support for OpenShift #241

hishamanver opened this issue Sep 13, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@hishamanver
Copy link

hishamanver commented Sep 13, 2024

Is your feature request related to a problem? Please describe.

I attempted to deploy temporal via helm (https://github.com/temporalio/helm-charts/tree/main) onto an openshift cluster.

Ran into issues running the temporal server and temporal ui containers on openshift due to security constraints (running on openshift - https://cloud.redhat.com/blog/a-guide-to-openshift-and-uids)

Identified the root cause to be the following sections:

Essentially what we are observing is openshift enforces specific UID and GID for the running containers that do not match the predefined values in the image definition and therefore fail with the following error:

TEMPORAL_ADDRESS is not set, setting it to 100.72.8.241:7233
2024/09/13 06:13:46 unable to create open /etc/temporal/config/docker.yaml: permission denied

Describe the solution you'd like

Dockerfile definition should not pin specific UIDs for non root user enforcement, but instead ensure that all directories that are required for functionality have sufficient privileges.

To get around this issue the following Dockerfile was used and confirmed to work

FROM temporalio/server:1.25.0

RUN chmod o+w /etc/temporal/config/

@mohan-alpheya
Copy link

The below article explains what needs to done to use single Dockerfile to create an image that functions correctly, both on OpenShift and on Kubernetes.

https://developers.redhat.com/blog/2020/10/26/adapting-docker-and-kubernetes-containers-to-run-on-red-hat-openshift-container-platform#group_ownership_and_file_permission

image

@robholland
Copy link
Collaborator

We will be removing the need for Temporal to write to the filesytem for our docker containers, which will avoid this issue.

@robholland
Copy link
Collaborator

Relevant PR: temporalio/temporal#6251

@mohan-alpheya
Copy link

temporalio/ui also writes to the filesytem. the above PR fix ui image also?

@robholland
Copy link
Collaborator

That would need to be handled separately, I'll look at this once we've fixed it for Temporal server. temporalio/ui#1703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants