Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker Commands being sent with empty names in the wild #2412

Open
Sushisource opened this issue Feb 10, 2025 · 1 comment
Open

Marker Commands being sent with empty names in the wild #2412

Sushisource opened this issue Feb 10, 2025 · 1 comment

Comments

@Sushisource
Copy link
Member

Expected Behavior

Marker commands should never be sent to server with an empty marker name.

Actual Behavior

That happened

Steps to Reproduce the Problem

Unclear. Some user workflows were seen encountering this error on workflow completion:

BadRecordMarkerAttributes: MarkerName is not set on RecordMarkerCommand.

From what I could tell looking at the code briefly, the only way it seemed like this might happen is if the marker command was constructed while replaying was true, and then it later became false and sent off the command.

Specifications

This was definitely Java SDK, which we determined by seeing the stack trace query. Not clear which version. Java needs to do #1838

@Quinn-With-Two-Ns
Copy link
Contributor

Quinn-With-Two-Ns commented Feb 10, 2025

Commands aren't sent on replay, there was an old bug #1558 can you confirm this happend with the latest SDK ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants