Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate MSVC compiler & linker switches #66

Open
tlemo opened this issue Jun 25, 2021 · 0 comments
Open

Consolidate MSVC compiler & linker switches #66

tlemo opened this issue Jun 25, 2021 · 0 comments
Labels
windows Issues and changes related to Windows support

Comments

@tlemo
Copy link
Contributor

tlemo commented Jun 25, 2021

Try to deduplicate / consolidate the MSVC switches:

runtime/build_defs.bzl

Lines 39 to 84 in b570a19

"@tf_runtime//:windows": [
"-Zc:inline",
"-Zc:strictStrings",
"-Zc:rvalueCast",
"-Oi",
"-wd4141",
"-wd4146",
"-wd4180",
"-wd4244",
"-wd4258",
"-wd4267",
"-wd4291",
"-wd4345",
"-wd4351",
"-wd4355",
"-wd4456",
"-wd4457",
"-wd4458",
"-wd4459",
"-wd4503",
"-wd4624",
"-wd4722",
"-wd4800",
"-wd4100",
"-wd4127",
"-wd4512",
"-wd4505",
"-wd4610",
"-wd4510",
"-wd4702",
"-wd4245",
"-wd4706",
"-wd4310",
"-wd4701",
"-wd4703",
"-wd4389",
"-wd4611",
"-wd4805",
"-wd4204",
"-wd4577",
"-wd4091",
"-wd4592",
"-wd4319",
"-wd4324",
"-w14062",
"-we4238",

"-Zc:inline",
"-Zc:strictStrings",
"-Zc:rvalueCast",
"-Oi",
"-wd4141",
"-wd4146",
"-wd4180",
"-wd4244",
"-wd4258",
"-wd4267",
"-wd4291",
"-wd4345",
"-wd4351",
"-wd4355",
"-wd4456",
"-wd4457",
"-wd4458",
"-wd4459",
"-wd4503",
"-wd4624",
"-wd4722",
"-wd4800",
"-wd4100",
"-wd4127",
"-wd4512",
"-wd4505",
"-wd4610",
"-wd4510",
"-wd4702",
"-wd4245",
"-wd4706",
"-wd4310",
"-wd4701",
"-wd4703",
"-wd4389",
"-wd4611",
"-wd4805",
"-wd4204",
"-wd4577",
"-wd4091",
"-wd4592",
"-wd4319",
"-wd4324",
"-w14062",
"-we4238",

...

@tlemo tlemo added the windows Issues and changes related to Windows support label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Issues and changes related to Windows support
Projects
None yet
Development

No branches or pull requests

1 participant