--recursive needs .tflint.hcl in each directory #1872

yury-komarov-contextlabs · 2023-10-02T17:46:40Z

yury-komarov-contextlabs
Oct 2, 2023

Summary

I'm trying to scan my whole repository with TF modules and when i'm enabling --recursive flag, tflint trying to get config in each directory on the way. As result, it's running with default values, not my custom one.

Command

TFLINT_LOG=debug tflint --recursive --config "$(pwd)/.tflint.hcl"

Terraform Configuration

TFLint Configuration

config {
  format = "compact"
  force  = true
}

plugin "terraform" {
  enabled = true
  preset  = "recommended"
}

rule "terraform_required_version" {
  enabled = false
}

Output

19:40:28 config.go:137: [INFO] Load config: .tflint.hcl
19:40:28 config.go:269: [DEBUG] Config loaded
19:40:28 config.go:270: [DEBUG]   Module: false
19:40:28 config.go:271: [DEBUG]   ModuleSet: false
19:40:28 config.go:272: [DEBUG]   Force: true
19:40:28 config.go:273: [DEBUG]   ForceSet: true
19:40:28 config.go:274: [DEBUG]   DisabledByDefault: false
19:40:28 config.go:275: [DEBUG]   DisabledByDefaultSet: false
19:40:28 config.go:276: [DEBUG]   PluginDir:
19:40:28 config.go:277: [DEBUG]   PluginDirSet: false
19:40:28 config.go:278: [DEBUG]   Format: compact
19:40:28 config.go:279: [DEBUG]   FormatSet: true
19:40:28 config.go:280: [DEBUG]   Varfiles:
19:40:28 config.go:281: [DEBUG]   Variables:
19:40:28 config.go:282: [DEBUG]   Only:
19:40:28 config.go:283: [DEBUG]   IgnoreModules:
19:40:28 config.go:287: [DEBUG]   Rules:
19:40:28 config.go:291: [DEBUG]   Plugins:
19:40:28 config.go:293: [DEBUG]     terraform: enabled=true, version=, source=
19:40:28 option.go:71: [DEBUG] CLI Options
19:40:28 option.go:72: [DEBUG]   Module: false
19:40:28 option.go:73: [DEBUG]   Force: false
19:40:28 option.go:74: [DEBUG]   Format:
19:40:28 option.go:75: [DEBUG]   Varfiles:
19:40:28 option.go:76: [DEBUG]   Variables:
19:40:28 option.go:77: [DEBUG]   EnableRules:
19:40:28 option.go:78: [DEBUG]   DisableRules:
19:40:28 option.go:79: [DEBUG]   Only:
19:40:28 option.go:80: [DEBUG]   EnablePlugins:
19:40:28 option.go:81: [DEBUG]   IgnoreModules:
19:40:28 loader.go:38: [INFO] Initialize new loader
19:40:28 config.go:137: [INFO] Load config: .tflint.hcl
19:40:28 config.go:147: [INFO] file not found
19:40:28 config.go:155: [INFO] Load config: /Users/yury.komarov/.tflint.hcl
19:40:28 config.go:163: [INFO] file not found
19:40:28 config.go:165: [INFO] Use default config
19:40:28 config.go:320: [INFO] The `terraform` plugin block is not found. Enable the plugin `terraform` automatically
19:40:28 option.go:71: [DEBUG] CLI Options
19:40:28 option.go:72: [DEBUG]   Module: false
19:40:28 option.go:73: [DEBUG]   Force: false
19:40:28 option.go:74: [DEBUG]   Format:
19:40:28 option.go:75: [DEBUG]   Varfiles:
19:40:28 option.go:76: [DEBUG]   Variables:
19:40:28 option.go:77: [DEBUG]   EnableRules:
19:40:28 option.go:78: [DEBUG]   DisableRules:
19:40:28 option.go:79: [DEBUG]   Only:
19:40:28 option.go:80: [DEBUG]   EnablePlugins:
19:40:28 option.go:81: [DEBUG]   IgnoreModules:
19:40:28 loader.go:38: [INFO] Initialize new loader
19:40:28 config.go:137: [INFO] Load config: .tflint.hcl
19:40:28 config.go:147: [INFO] file not found
19:40:28 config.go:155: [INFO] Load config: /Users/yury.komarov/.tflint.hcl
19:40:28 config.go:163: [INFO] file not found
19:40:28 config.go:165: [INFO] Use default config
19:40:28 config.go:320: [INFO] The `terraform` plugin block is not found. Enable the plugin `terraform` automatically
19:40:28 option.go:71: [DEBUG] CLI Options
19:40:28 option.go:72: [DEBUG]   Module: false
19:40:28 option.go:73: [DEBUG]   Force: false
19:40:28 option.go:74: [DEBUG]   Format:
19:40:28 option.go:75: [DEBUG]   Varfiles:
19:40:28 option.go:76: [DEBUG]   Variables:
19:40:28 option.go:77: [DEBUG]   EnableRules:
19:40:28 option.go:78: [DEBUG]   DisableRules:
19:40:28 option.go:79: [DEBUG]   Only:
19:40:28 option.go:80: [DEBUG]   EnablePlugins:
19:40:28 option.go:81: [DEBUG]   IgnoreModules:
***
178 issue(s) found:

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on  line 0:
   (source code not available)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.4.0/docs/rules/terraform_required_version.md

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on  line 0:
   (source code not available)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.4.0/docs/rules/terraform_required_version.md

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on  line 0:
   (source code not available)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.4.0/docs/rules/terraform_required_version.md
***

TFLint Version

0.48.0

Terraform Version

No response

Operating System

Linux
macOS
Windows

bendrucker · 2023-10-03T02:26:26Z

bendrucker
Oct 3, 2023
Maintainer

Unable to reproduce. The INFO level log Load config: ... prints exactly what is provided. It's easiest to see this by not giving the file the default .tflint.hcl name to guarantee it won't be auto loaded. But the result is identical regardless of filename.

TFLINT_LOG=debug tflint --recursive --config "$(pwd)/.tflint.hcl"
19:24:22 config.go:137: [INFO] Load config: /var/folders/m6/7nt7y_s54lsbrwsjb_xsmx7m0000gn/T/tflconfig/.tflint.hc

While your command looks right the lack of an absolute path in the logs suggests that an absolute path is not actually being passed. No idea what the discrepancy is but there's also no indication it's a bug based on the output given.

0 replies

strophy · 2024-06-04T13:52:15Z

strophy
Jun 4, 2024

Hi @bendrucker I'm able to reproduce this under Ubuntu 24.04 as well:

~/Code/infra/terraform$ tflint --version
TFLint version 0.51.1
+ ruleset.terraform (0.7.0-bundled)

~/Code/infra/terraform$ pwd
/home/leon/Code/infra/terraform

~/Code/infra/terraform$ tree -L 2
.
├── environments
│   ├── nucleus
│   ├── prod
│   └── services
└── modules
    ├── elasticsearch
    ├── emqx
    ├── gateway
    ├── iam
    ├── lims
    ├── n8n
    ├── stellar-register
    └── vpc

~/Code/infra/terraform$ cat .tflint.hcl 
tflint {
  required_version = "~> 0.51"
}

plugin "terraform" {
  enabled = true
  preset  = "recommended"
}

plugin "aws" {
  enabled = true
  version = "0.31.0"
  source  = "github.com/terraform-linters/tflint-ruleset-aws"
}

rule "terraform_required_providers" {
  enabled = false
}

rule "terraform_required_version" {
  enabled = false
}

Running TFLINT_LOG=debug tflint --recursive shows it is not finding the config file as it traverses the directories in the tree shown above.

~/Code/infra/terraform$ TFLINT_LOG=debug tflint --recursive
│ An output to stderr found in modules

15:39:18 config.go:175: [INFO] Load config: .tflint.hcl
15:39:18 config.go:183: [INFO] file not found
15:39:18 config.go:190: [INFO] Load config: /home/leon/.tflint.hcl
15:39:18 config.go:198: [INFO] file not found
15:39:18 config.go:201: [INFO] Use default config
15:39:18 config.go:476: [INFO] The "terraform" plugin block is not found. Enable the plugin "terraform" automatically
15:39:18 option.go:91: [DEBUG] CLI Options
15:39:18 option.go:92: [DEBUG]   CallModuleType: local
15:39:18 option.go:93: [DEBUG]   Force: true
15:39:18 option.go:94: [DEBUG]   Format: 
15:39:18 option.go:95: [DEBUG]   Varfiles: 
15:39:18 option.go:96: [DEBUG]   Variables: 
15:39:18 option.go:97: [DEBUG]   EnableRules: 
15:39:18 option.go:98: [DEBUG]   DisableRules: 
15:39:18 option.go:99: [DEBUG]   Only: 
15:39:18 option.go:100: [DEBUG]   EnablePlugins: 
15:39:18 option.go:101: [DEBUG]   IgnoreModules:
15:39:18 loader.go:39: [INFO] Initialize new loader


│ An output to stderr found in environments

15:39:18 config.go:175: [INFO] Load config: .tflint.hcl
15:39:18 config.go:183: [INFO] file not found
15:39:18 config.go:190: [INFO] Load config: /home/leon/.tflint.hcl
15:39:18 config.go:198: [INFO] file not found
15:39:18 config.go:201: [INFO] Use default config
15:39:18 config.go:476: [INFO] The "terraform" plugin block is not found. Enable the plugin "terraform" automatically
15:39:18 option.go:91: [DEBUG] CLI Options
15:39:18 option.go:92: [DEBUG]   CallModuleType: local
15:39:18 option.go:93: [DEBUG]   Force: true
15:39:18 option.go:94: [DEBUG]   Format: 
15:39:18 option.go:95: [DEBUG]   Varfiles: 
15:39:18 option.go:96: [DEBUG]   Variables: 
15:39:18 option.go:97: [DEBUG]   EnableRules: 
15:39:18 option.go:98: [DEBUG]   DisableRules: 
15:39:18 option.go:99: [DEBUG]   Only: 
15:39:18 option.go:100: [DEBUG]   EnablePlugins: 
15:39:18 option.go:101: [DEBUG]   IgnoreModules:
15:39:18 loader.go:39: [INFO] Initialize new loader


│ An output to stderr found in .

15:39:18 config.go:175: [INFO] Load config: .tflint.hcl
15:39:18 config.go:347: [DEBUG] Config loaded
15:39:18 config.go:348: [DEBUG]   CallModuleType: local
15:39:18 config.go:349: [DEBUG]   CallModuleTypeSet: false
15:39:18 config.go:350: [DEBUG]   Force: false
15:39:18 config.go:351: [DEBUG]   ForceSet: false
15:39:18 config.go:352: [DEBUG]   DisabledByDefault: false
15:39:18 config.go:353: [DEBUG]   DisabledByDefaultSet: false
15:39:18 config.go:354: [DEBUG]   PluginDir: 
15:39:18 config.go:355: [DEBUG]   PluginDirSet: false
15:39:18 config.go:356: [DEBUG]   Format: 
15:39:18 config.go:357: [DEBUG]   FormatSet: false
15:39:18 config.go:358: [DEBUG]   Varfiles: 
15:39:18 config.go:359: [DEBUG]   Variables: 
15:39:18 config.go:360: [DEBUG]   Only: 
15:39:18 config.go:361: [DEBUG]   IgnoreModules:
15:39:18 config.go:365: [DEBUG]   Rules:
15:39:18 config.go:367: [DEBUG]     terraform_required_providers: false
15:39:18 config.go:367: [DEBUG]     terraform_required_version: false
15:39:18 config.go:369: [DEBUG]   Plugins:
15:39:18 config.go:371: [DEBUG]     terraform: enabled=true, version=, source=
15:39:18 config.go:371: [DEBUG]     aws: enabled=true, version=0.31.0, source=github.com/terraform-linters/tflint-ruleset-aws
15:39:18 option.go:91: [DEBUG] CLI Options
15:39:18 option.go:92: [DEBUG]   CallModuleType: local
15:39:18 option.go:93: [DEBUG]   Force: true
15:39:18 option.go:94: [DEBUG]   Format: 
15:39:18 option.go:95: [DEBUG]   Varfiles: 
15:39:18 option.go:96: [DEBUG]   Variables: 
15:39:18 option.go:97: [DEBUG]   EnableRules: 
15:39:18 option.go:98: [DEBUG]   DisableRules: 
15:39:18 option.go:99: [DEBUG]   Only: 
15:39:18 option.go:100: [DEBUG]   EnablePlugins: 
15:39:18 option.go:101: [DEBUG]   IgnoreModules:
15:39:18 loader.go:39: [INFO] Initialize new loader


│ An output to stderr found in modules/emqx

15:39:18 config.go:175: [INFO] Load config: .tflint.hcl
15:39:18 config.go:183: [INFO] file not found
15:39:18 config.go:190: [INFO] Load config: /home/leon/.tflint.hcl
15:39:18 config.go:198: [INFO] file not found
15:39:18 config.go:201: [INFO] Use default config
15:39:18 config.go:476: [INFO] The "terraform" plugin block is not found. Enable the plugin "terraform" automatically
15:39:18 option.go:91: [DEBUG] CLI Options
15:39:18 option.go:92: [DEBUG]   CallModuleType: local
15:39:18 option.go:93: [DEBUG]   Force: true
15:39:18 option.go:94: [DEBUG]   Format: 
15:39:18 option.go:95: [DEBUG]   Varfiles: 
15:39:18 option.go:96: [DEBUG]   Variables: 
15:39:18 option.go:97: [DEBUG]   EnableRules: 
15:39:18 option.go:98: [DEBUG]   DisableRules: 
15:39:18 option.go:99: [DEBUG]   Only: 
15:39:18 option.go:100: [DEBUG]   EnablePlugins: 
15:39:18 option.go:101: [DEBUG]   IgnoreModules:
15:39:18 loader.go:39: [INFO] Initialize new loader
15:39:18 loader.go:81: [INFO] Building the root module while calling local child modules...
15:39:18 runner.go:46: [INFO] Initialize new runner for root
15:39:18 discovery.go:33: [INFO] Plugin "terraform" is not installed, but the bundled plugin is available.
15:39:18 discovery.go:54: [INFO] Plugin "terraform" found
15:39:18 [DEBUG] cmdrunner/cmd_runner.go:73: starting plugin: path=/usr/local/bin/tflint args=["/usr/local/bin/tflint", "--act-as-bundled-plugin"]
15:39:18 [DEBUG] cmdrunner/cmd_runner.go:80: plugin started: path=/usr/local/bin/tflint pid=378997
15:39:18 [DEBUG] [email protected]/client.go:825: waiting for RPC address: plugin=/usr/local/bin/tflint
15:39:18 [DEBUG] [email protected]/client.go:878: using plugin: version=11
15:39:18 [DEBUG] [email protected]/client.go:1214: tflint: 15:39:18 [DEBUG] [email protected]/server.go:419: plugin address: network=unix address=/tmp/plugin2835463047
15:39:18 [DEBUG] host2plugin/client.go:124: starting host-side gRPC server
15:39:18 [DEBUG] [email protected]/grpc_stdio.go:142: stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = error reading from server: EOF"
15:39:18 [INFO]  [email protected]/client.go:780: plugin process exited: plugin=/usr/local/bin/tflint id=378997
15:39:18 [DEBUG] [email protected]/client.go:558: plugin exited

.... snip .....
19 issue(s) found:

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on  line 0:
   (source code not available)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_required_version.md

Warning: terraform "required_version" attribute is required (terraform_required_version)

  on  line 0:
   (source code not available)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_required_version.md
.... snip .....
Warning: Missing version constraint for provider "aws" in `required_providers` (terraform_required_providers)

  on modules/n8n/main.tf line 138:
 138: resource "aws_ssm_parameter" "nonroot_password" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_required_providers.md

Warning: Missing version constraint for provider "aws" in `required_providers` (terraform_required_providers)

  on modules/stellar-register/main.tf line 116:
 116: resource "aws_route53_record" "backend" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_required_providers.md

Warning: Missing version constraint for provider "aws" in `required_providers` (terraform_required_providers)

  on modules/vpc/security.tf line 281:
 281: resource "aws_network_acl_rule" "private_allow_all_icmp_ingress" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.7.0/docs/rules/terraform_required_providers.md

Renaming the file to .tflint-rename.hcl and specifying it explicitly as shown by @yury-komarov-contextlabs :

~/Code/infra/terraform$ TFLINT_LOG=debug tflint --recursive --config "$(pwd)/.tflint-rename.hcl"
│ An output to stderr found in .

15:42:51 config.go:147: [INFO] Load config: /home/leon/Code/infra/terraform/.tflint-rename.hcl
15:42:51 config.go:347: [DEBUG] Config loaded
15:42:51 config.go:348: [DEBUG]   CallModuleType: local
15:42:51 config.go:349: [DEBUG]   CallModuleTypeSet: false
15:42:51 config.go:350: [DEBUG]   Force: false
15:42:51 config.go:351: [DEBUG]   ForceSet: false
15:42:51 config.go:352: [DEBUG]   DisabledByDefault: false
15:42:51 config.go:353: [DEBUG]   DisabledByDefaultSet: false
15:42:51 config.go:354: [DEBUG]   PluginDir: 
15:42:51 config.go:355: [DEBUG]   PluginDirSet: false
15:42:51 config.go:356: [DEBUG]   Format: 
15:42:51 config.go:357: [DEBUG]   FormatSet: false
15:42:51 config.go:358: [DEBUG]   Varfiles: 
15:42:51 config.go:359: [DEBUG]   Variables: 
15:42:51 config.go:360: [DEBUG]   Only: 
15:42:51 config.go:361: [DEBUG]   IgnoreModules:
15:42:51 config.go:365: [DEBUG]   Rules:
15:42:51 config.go:367: [DEBUG]     terraform_required_providers: false
15:42:51 config.go:367: [DEBUG]     terraform_required_version: false
15:42:51 config.go:369: [DEBUG]   Plugins:
15:42:51 config.go:371: [DEBUG]     terraform: enabled=true, version=, source=
15:42:51 config.go:371: [DEBUG]     aws: enabled=true, version=0.31.0, source=github.com/terraform-linters/tflint-ruleset-aws
15:42:51 option.go:91: [DEBUG] CLI Options
15:42:51 option.go:92: [DEBUG]   CallModuleType: local
15:42:51 option.go:93: [DEBUG]   Force: true
15:42:51 option.go:94: [DEBUG]   Format: 
15:42:51 option.go:95: [DEBUG]   Varfiles: 
15:42:51 option.go:96: [DEBUG]   Variables: 
15:42:51 option.go:97: [DEBUG]   EnableRules: 
15:42:51 option.go:98: [DEBUG]   DisableRules: 
15:42:51 option.go:99: [DEBUG]   Only: 
15:42:51 option.go:100: [DEBUG]   EnablePlugins: 
15:42:51 option.go:101: [DEBUG]   IgnoreModules:
15:42:51 loader.go:39: [INFO] Initialize new loader


│ An output to stderr found in environments

15:42:51 config.go:147: [INFO] Load config: /home/leon/Code/infra/terraform/.tflint-rename.hcl
15:42:51 config.go:347: [DEBUG] Config loaded
15:42:51 config.go:348: [DEBUG]   CallModuleType: local
15:42:51 config.go:349: [DEBUG]   CallModuleTypeSet: false
15:42:51 config.go:350: [DEBUG]   Force: false
15:42:51 config.go:351: [DEBUG]   ForceSet: false
15:42:51 config.go:352: [DEBUG]   DisabledByDefault: false
15:42:51 config.go:353: [DEBUG]   DisabledByDefaultSet: false
15:42:51 config.go:354: [DEBUG]   PluginDir: 
15:42:51 config.go:355: [DEBUG]   PluginDirSet: false
15:42:51 config.go:356: [DEBUG]   Format: 
15:42:51 config.go:357: [DEBUG]   FormatSet: false
15:42:51 config.go:358: [DEBUG]   Varfiles: 
15:42:51 config.go:359: [DEBUG]   Variables: 
15:42:51 config.go:360: [DEBUG]   Only: 
15:42:51 config.go:361: [DEBUG]   IgnoreModules:
15:42:51 config.go:365: [DEBUG]   Rules:
15:42:51 config.go:367: [DEBUG]     terraform_required_providers: false
15:42:51 config.go:367: [DEBUG]     terraform_required_version: false
15:42:51 config.go:369: [DEBUG]   Plugins:
15:42:51 config.go:371: [DEBUG]     terraform: enabled=true, version=, source=
15:42:51 config.go:371: [DEBUG]     aws: enabled=true, version=0.31.0, source=github.com/terraform-linters/tflint-ruleset-aws
15:42:51 option.go:91: [DEBUG] CLI Options
15:42:51 option.go:92: [DEBUG]   CallModuleType: local
15:42:51 option.go:93: [DEBUG]   Force: true
15:42:51 option.go:94: [DEBUG]   Format: 
15:42:51 option.go:95: [DEBUG]   Varfiles: 
15:42:51 option.go:96: [DEBUG]   Variables: 
15:42:51 option.go:97: [DEBUG]   EnableRules: 
15:42:51 option.go:98: [DEBUG]   DisableRules: 
15:42:51 option.go:99: [DEBUG]   Only: 
15:42:51 option.go:100: [DEBUG]   EnablePlugins: 
15:42:51 option.go:101: [DEBUG]   IgnoreModules:
15:42:51 loader.go:39: [INFO] Initialize new loader

.... snip .....

No warnings are returned from the second run, because the config file is applied correctly to each traversed directory when explicitly specified with an absolute path, and the terraform_required_providers and terraform_required_version rules are disabled as requested by my config. I believe @yury-komarov-contextlabs analysis is correct, the issue can be seen in both my logs and the his logs:

15:46:03 config.go:175: [INFO] Load config: .tflint.hcl
15:46:03 config.go:183: [INFO] file not found
15:46:03 config.go:190: [INFO] Load config: /home/leon/.tflint.hcl
15:46:03 config.go:198: [INFO] file not found
15:46:03 config.go:201: [INFO] Use default config
15:46:03 config.go:476: [INFO] The "terraform" plugin block is not found. Enable the plugin "terraform" automatically

tflint is trying to find the config file in the currently processed directory and $HOME, but not in the directory from which I am running the tflint --recursive command (in this case $HOME/Code/infra/terraform).

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

--recursive needs .tflint.hcl in each directory #1872

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

Select a reply

--recursive needs .tflint.hcl in each directory #1872

yury-komarov-contextlabs Oct 2, 2023

Summary

Command

Terraform Configuration

TFLint Configuration

Output

TFLint Version

Terraform Version

Operating System

Replies: 2 comments

bendrucker Oct 3, 2023 Maintainer

strophy Jun 4, 2024

yury-komarov-contextlabs
Oct 2, 2023

bendrucker
Oct 3, 2023
Maintainer

strophy
Jun 4, 2024