Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: add error when using target-arrowhead on shape #1685

Closed
gavin-ts opened this issue Oct 28, 2023 · 0 comments · Fixed by #1686
Closed

compiler: add error when using target-arrowhead on shape #1685

gavin-ts opened this issue Oct 28, 2023 · 0 comments · Fixed by #1686
Labels
bug Something isn't working compiler

Comments

@gavin-ts
Copy link
Contributor

Screenshot 2023-10-27 at 8 46 12 PM

source-arrowhead and target-arrowhead should only be valid on connections. Or at the very least arrowhead shapes should be detected as invalid when using these keywords as a shape id. (but I think it makes more sense to reserve them for connections only)
Screenshot 2023-10-27 at 8 48 54 PM

right now it creates an invalid shape in z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add compiler error when using arrowheads on shape gavin-ts/d2
1 participant
@gavin-ts