Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain characters breaking display #1811

Closed
IlanCosman opened this issue Jan 22, 2024 · 2 comments · Fixed by #2100
Closed

Certain characters breaking display #1811

IlanCosman opened this issue Jan 22, 2024 · 2 comments · Fixed by #2100

Comments

@IlanCosman
Copy link

IlanCosman commented Jan 22, 2024 •
edited
Loading

The following code using ascii 254 (■) doesn't display "bar".

legend: |md
  ■ foo bar
|

https://play.d2lang.com/?script=yklNT81LsVKoyU3hUlB4NG2BQlp-vkJSYhFXDRcgAAD__w%3D%3D&

image

If we replace the square with a traditional character like "a", it works.

legend: |md
  a foo bar
|

https://play.d2lang.com/?script=yklNT81LsVKoyU3hUlBIVEjLz1dISiziquECBAAA__8%3D&

image
@cyborg-ts cyborg-ts added this to D2 Jan 22, 2024
@IlanCosman IlanCosman changed the title Certain non-ascii characters breaking display Certain characters breaking display Jan 22, 2024
@bo-ku-ra
Copy link
Contributor

bo-ku-ra commented Jan 22, 2024 •
edited
Loading

this is weird
https://play.d2lang.com/?script=ejRtgZVCTW4Kl4LCo2kLFNLy8xWSEou4argeTVuIkFiILDG9Hy4xvR9Fohsh0Y0i0YaQaEORaEdItKNYvglh-SYUic0Iic0oEnsQEntQJPYiJPYiSzTshks07EZxVR9E4tH0PiRhQAAAAP__&

on windows, this is different results between firefox and edge.

edge
image

firefox
image

@alixander alixander mentioned this issue Sep 16, 2024
Merged
@alixander
Copy link
Collaborator

thank you @IlanCosman for raising the issue and thanks @bo-ku-ra as always for the thorough test cases

@github-project-automation github-project-automation bot moved this to Done in D2 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support latin-1 and geometric shape unicode chars alixander/d2
3 participants
@alixander @IlanCosman @bo-ku-ra