Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow child nodes for images within sequence diagrams #1820

Closed
dunkelziffer opened this issue Jan 28, 2024 · 1 comment
Closed

Allow child nodes for images within sequence diagrams #1820

dunkelziffer opened this issue Jan 28, 2024 · 1 comment

Comments

@dunkelziffer
Copy link

Preventing further nesting inside of nodes with shape: image is a reasonable decision. However, containers with shape: sequence_diagram completely change the rendering of nested nodes. Suddenly child nodes get rendered below their parents instead of nested within them. Now having child nodes makes sense again for images.

The following should render correctly:

shape: sequence_diagram
alice: {
  shape: image
  icon: https://icons.terrastruct.com/essentials%2F365-user.svg
}
bob: {
  shape: image
  icon: https://icons.terrastruct.com/azure%2FCompute%20Service%20Color%2FCloud%20Services.svg
}
alice.a -> bob: request
alice.a <- bob: response
@cyborg-ts cyborg-ts added this to D2 Jan 28, 2024
@alixander
Copy link
Collaborator

closed by #2061

@github-project-automation github-project-automation bot moved this to Done in D2 Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants