Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KafkaAdminClient for quota enforcement + upgrade Kafka libs to 2.6 #55

Open
danielfritsch opened this issue Dec 17, 2021 · 0 comments

Comments

@danielfritsch
Copy link
Contributor

With the current Kafka version (2.4.1), quota enforcement was implemented through the use of a Zookeeper admin client, as using the KafkaAdminClient only support quota configuration with Kafka >= 2.6, client and server-side.

With the introduction of quota enforcement functionality in this project, we had to add in the Kafka server library (which contains the ZK admin client code), which in turn required complicating the dependency environment with various Scala libraries, and scala bazel_rules.

When we are ready to upgrade Kafka to >= 2.6, it would make sense to bring remove these Scala dependencies and go back to a light-weight dependencies.yaml with just Java libraries. This entails

  • removing Kafka server library
  • upgrading kafka-client library
  • remove unneeded dependencies that were added in the below PRs
  • use KafkaAdminClient to for quota configuration

#54
#53

rohanag12 pushed a commit to rohanag12/kafka-helmsman that referenced this issue Sep 6, 2022
Upgrade Kafka dependencies to version 2.8.1, which is the latest release
in the 2.x.x series. This release depends on Zookeeper 3.5.x, so update
that dependency to the latest version as well.

This upgrade allows using newer Kafka features. One such feature that has
an open ticket is to enforce quotas using the admin client instead of the
old zookeeper client (teslamotors#55).
shrijeet-tesla pushed a commit that referenced this issue Sep 7, 2022
Upgrade Kafka dependencies to version 2.8.1, which is the latest release
in the 2.x.x series. This release depends on Zookeeper 3.5.x, so update
that dependency to the latest version as well.

This upgrade allows using newer Kafka features. One such feature that has
an open ticket is to enforce quotas using the admin client instead of the
old zookeeper client (#55).

Co-authored-by: Rohan Agarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant