converge doesn't exit with proper exit code

[Stromweld]

Using latest versions of kitchen-dokken and test-kitchen when running a converge if the chef-client fails convergence due to an error kitchen converge exits with 0 exit code indicating a success.

[Stromweld]

I was able to narrow down the issue this line https://github.com/test-kitchen/kitchen-dokken/blob/main/lib/kitchen/provisioner/dokken.rb#L77

when clean_dokken_sandbox is set to false the return negates the exception and test-kitchen returns 0 for failed convergence. When set to true it returns the correct convergence error.

[damacus]

@Stromweld do you think #319 fixed this?

[Stromweld]

yes it is working now.