Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Module support #42

Open
bryanbcook opened this issue Nov 13, 2023 · 3 comments
Open

ES Module support #42

bryanbcook opened this issue Nov 13, 2023 · 3 comments

Comments

@bryanbcook
Copy link
Contributor

I attempted to add d3-time-format to the project but received an error similar to 'change the require to a dynamic import'.

This would require all the require statements to be converted over to import syntax

References:

@ASaiAnudeep
Copy link
Member

Is it possible to use day.js instead of d3-time-format?

@bryanbcook
Copy link
Contributor Author

I can take a look at day.js

Is there a reason the project doesn't use ESM? I have a local branch with the appropriate changes. I can push it if you'd like to test it out.

@ASaiAnudeep
Copy link
Member

We utilize require for loading dynamic modules in the reporter. I presume that if we transition this package to ESM, a corresponding conversion of the reporter and all the upstream projects will be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants