Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Library source does not match the bytecode for class GenericContainer #9220

Open
jpmartins opened this issue Sep 12, 2024 · 3 comments
Labels

Comments

@jpmartins
Copy link

Module

Core

Testcontainers version

1.20.1

Using the latest Testcontainers version?

Yes

Host OS

macOs 14.6.1

Host Arch

ARM (Apple M2)

Docker version

-

What happened?

While trying to debug testcontainers potential bug, I discovered that sources published are not the correct.

The testcontainers-1.20.1-sources.jar content does not match testcontainers-1.20.1.jar content.

For example the GenericContainer class in testcontainers-1.20.1-sources.jar does not have public @nonnull List getExtraHosts() method... that is present in javadoc and in the library class at runtime.

Relevant log output

No response

Additional Information

No response

@kiview
Copy link
Member

kiview commented Sep 12, 2024

Hey @jpmartins, thanks for reporting.

We are using the delombok task from the Gradle-Lombok plugin we are using.

I don't know what else we can do to mitigate the situation (besides removing Lombok altogether), suggestions are welcome.

@wendigo
Copy link

wendigo commented Oct 7, 2024

This is causing our project to fail with the cryptic error:

java: com.sun.tools.javac.code.Symbol$CompletionFailure: class file for lombok.NonNull not found

when we use JDK 23 to compile a project in IntelliJ so the question is: why the import lombok.NonNull; is retained in the source code of the JdbcDatabaseContainer ?

@wendigo
Copy link

wendigo commented Oct 7, 2024

repro-intellij.zip

Here's a sample repro that will fail to build when JDK 23 is used, due to the import lombok.Nonnull and it's usages being retained in the compiled JdbcDatabaseContainer class. It seems that delombok plugin is not doing its job properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants