Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution Guide #68

Open
rayphi opened this issue Apr 28, 2021 · 16 comments
Open

Contribution Guide #68

rayphi opened this issue Apr 28, 2021 · 16 comments

Comments

@rayphi
Copy link
Contributor

rayphi commented Apr 28, 2021

Hey,

YES, more than happy to receive a pull request against the 'development' branch...

Did you answer me a long time ago.

Unfortunately, I think I'm missing a little guide to be able to work with the project at all.
Would it be possible that you could help us out with this?

What I get to see when I open the Solution:
TestCop_SolutionErrors.txt
@MarkSandy
Copy link

First, you need to "restore all nuget packages for the solution" through a rightclick on the solution
Then you must adapt the nuget.buid.bat by setting the OUTDIR in line #4 to your local binary output path
Currently the extracted WAVEID in the .bat file does not match the latest Resharper version as
JetBrains.Platform.SDK has not been updated yet.

To get a working package for the latest R# version, simply overwrite the WAVEID in line 16 with "SET WAVEID=211

Now build the release. The packages will appear in the binary folder bin/Release/9.0

Install and enjoy.

@EdvardasDlugauskas
Copy link

Mark also posted these instructions in a previous issue #65

You can compile it yourself and install it via local nuget.
You need to edit the nuget.build.bar though.

1. restore all nuget packages (rightclick on the solution)

2. configure the OUTDIR to point to your local binary output folder

3. As Jetbrains.Platform.SDK hasn't been updated yet, you need to manually set the WAVEID to 211 in line 15

4. Edit and update the Testcop.nuspec file to show the new version number and target R# version

5. build and install the local nupkg according to the description on the jetbrains help page

These are for getting a local nuget, but ideally we'd like an official release. I imagine there's a couple more steps involved from that point, but maybe we could get a PR going to streamline this for Mark?

@rayphi if you're still up to the task, do the instructions Mark posted help at all with your errors?

@EdvardasDlugauskas EdvardasDlugauskas mentioned this issue May 1, 2021
Closed
@EdvardasDlugauskas
Copy link

@MarkSandy so for a non-hacky solution, we are waiting for changes from ReSharper SDK?

@rayphi

This comment has been minimized.

Sign in to view
@MarkSandy
Copy link

MarkSandy commented May 3, 2021 via email

@rayphi

This comment has been minimized.

Sign in to view
@rayphi

This comment has been minimized.

Sign in to view
@EdvardasDlugauskas
Copy link

Looking at the history in AppVeyor, did it ever succeed? 🤔

Judging by this error

1) SetUp Error : TestCop.Plugin.Tests.Highlighting.ShouldBePublicWarningTests
System.Exception : Can't restore NuGet packages
Data:
  NuGet.Source.#1: jb-gallery [http://jb-gallery.azurewebsites.net/api/v2/]
  NuGet.Source.#2: nuget.org [http://www.nuget.org/api/v2/]
  TempDataPath: C:\Users\appveyor\AppData\Local\Temp\1\JetBrains\Wywypyd
  Framework: .NETFramework,Version=v4.6.0.0
  RenderedExceptionMessage: Can't restore NuGet packages Value cannot be null. Parameter name: packagesFolderPath
  RenderedExceptionDataWtihSensitiveInfo: Can't restore NuGet packages Value cannot be null. Parameter name: packagesFolderPath

...it also looks like it was due to some JetBrains.TestFramework.JetNuGet.NuGetRestoreHelper.Restore, so maybe this was an integration test? Maybe some configuration was not updated

@rayphi

This comment has been minimized.

Sign in to view
@rayphi

This comment has been minimized.

Sign in to view
@rayphi rayphi mentioned this issue May 5, 2021
Merged
@testcop
Copy link
Owner

testcop commented May 23, 2021

@rayphi Thanks for the PR and the extra code changes !

@testcop
Copy link
Owner

testcop commented May 23, 2021

Submitted to Jetbrains - will be available in a couple of days

@rayphi
Copy link
Contributor Author

rayphi commented May 23, 2021

Glad to "see" you back here - Thank you for submitting!"

Now that I've gone through the entire update process here 😬 do you have a specific order to successfully update all the dependencies or do you kick them all out first to reinstall them?

@testcop
Copy link
Owner

testcop commented May 24, 2021 •
edited
Loading

The build will attempt to publish the nuget package to C:\SourceCode - so create the folder or edit the file nuget.build.bat

  • Open up manage NuGet Packages for Solution
    ** upgrade JetBrains.Resharper.SDK Nuget package
    ** upgrade JetBrains.Resharper.SDK.Tests Nuget package
  • Close project and reopen
  • Now, compile and fix breakages
  • Run unit tests (they are slow but pass)

No need to update the WAVE id as it should be discovered by the script nuget.build.bat
Within Resharper add the folder C:\SourceCode as a location to look for extensions and install....

I will create a page to guide the next dev...

@MarkSandy Thanks for your PR too ! I will pick out some of your ideas

@rayphi
Copy link
Contributor Author

rayphi commented May 24, 2021

Ok that's exactly what I did! But it always broke off because some dependencies could not be resolved or caused conflicts.

Do you have special install/update/uninstall settings in the Solution Package Manager?

@testcop
Copy link
Owner

testcop commented May 24, 2021

Jetbrains often release or update the tests package later - you may have needed to wait a few days.

@rayphi rayphi mentioned this issue Apr 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rayphi @EdvardasDlugauskas @testcop @MarkSandy