Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add http_proxy support to the Wget() fake process #2

Open
freeekanayaka opened this issue Feb 21, 2019 · 0 comments
Open

Add http_proxy support to the Wget() fake process #2

freeekanayaka opened this issue Feb 21, 2019 · 0 comments

Comments

@freeekanayaka
Copy link
Member

We should teach to the fake Wget() how to deal with proxy-related environment variables. See also jenkinsci/jenkins-charm#53.
dannf pushed a commit to dannf/jenkins-charm that referenced this issue Feb 22, 2019
Try JUJU_CHARM_*_PROXY settings when fetching jenkins deb
95b5904 
If our model has juju proxy settings and we've been told to
fetch a specific deb, set the corresponding *_proxy variables
when doing so. If the user has set JUJU HTTP(S)/FTP proxies,
but has pointed us to an internally hosted deb, hopefully
they've also set JUJU_CHARM_NO_PROXY appropriately. But,
just in case, leave the fallback of fetching w an unmodified
environment.

Skip coverage test for wget failures until we have the
necessary fixture support. See:
 testing-cabal/systemfixtures#2
dannf pushed a commit to dannf/jenkins-charm that referenced this issue Feb 22, 2019
Try JUJU_CHARM_*_PROXY settings when fetching jenkins deb
56a96dd 
If our model has juju proxy settings and we've been told to
fetch a specific deb, set the corresponding *_proxy variables
when doing so. If the user has set JUJU HTTP(S)/FTP proxies,
but has pointed us to an internally hosted deb, hopefully
they've also set JUJU_CHARM_NO_PROXY appropriately. But,
just in case, leave the fallback of fetching w an unmodified
environment.

Skip coverage test for wget failures until we have the
necessary fixture support. See:
 testing-cabal/systemfixtures#2
dannf pushed a commit to dannf/jenkins-charm that referenced this issue Mar 5, 2019
Try JUJU_CHARM_*_PROXY settings when fetching jenkins deb
04fccc5 
If our model has juju proxy settings and we've been told to
fetch a specific deb, set the corresponding *_proxy variables
when doing so. If the user has set JUJU HTTP(S)/FTP proxies,
but has pointed us to an internally hosted deb, hopefully
they've also set JUJU_CHARM_NO_PROXY appropriately. But,
just in case, leave the fallback of fetching w an unmodified
environment.

Skip coverage test for wget failures until we have the
necessary fixture support. See:
 testing-cabal/systemfixtures#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@freeekanayaka