Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile syntax highlight bug, caused by comments #17

Open
aeschli opened this issue Aug 11, 2017 · 2 comments
Open

Makefile syntax highlight bug, caused by comments #17

aeschli opened this issue Aug 11, 2017 · 2 comments

Comments

@aeschli
Copy link

aeschli commented Aug 11, 2017

From @Leedehai on June 19, 2017 20:22

  • VSCode Version: 1.13.1
  • OS Version: macOS 10.12.5

Steps to Reproduce:
In this Makefile snippet, the variable "HCC_LIB_OBJ" in the second line is not properly colored, due to comment at the end of the first line. If the comment is removed, "HCC_LIB_OBJ" is colored correctly. But "HCC_LIB_OBJ"'s colorization should not be affected by whether there is a comment in the preceding line.
image
image

Copied from original issue: microsoft/vscode#29048
@aeschli
Copy link
Author

aeschli commented Aug 11, 2017

Reproduced with

s = b b #eeee
c = d d d

@aeschli aeschli mentioned this issue Aug 11, 2017
Closed
@fadeevab
Copy link

This issue is fixed in pull request: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fadeevab @aeschli