Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tests for liquidation cancellation #153

Open
gkaracha opened this issue Jun 8, 2021 · 2 comments
Open

Missing tests for liquidation cancellation #153

gkaracha opened this issue Jun 8, 2021 · 2 comments
Labels
testing The issue relates to testing

Comments

@gkaracha
Copy link
Contributor

gkaracha commented Jun 8, 2021

Due to the specific conditions needed for the cancellation of a liquidation, we currently have no test where Checker.entrypoint_cancel_liquidation_slice succeeds in returning a liquidation slice back to its burrow. Now that it's been getting easier to write e2e tests it's probably time to add tests for more intricate scenaria where cancellation is possible.

@gkaracha gkaracha added the testing The issue relates to testing label Jun 9, 2021
@dorranh
Copy link
Contributor

dorranh commented Jul 14, 2021

@gkaracha, would you consider this issue resolved after #193, or would you prefer that we add additional tests for this case?

@gkaracha
Copy link
Contributor Author

@dorranh As far as the e2e tests are concerned I do consider it resolved indeed! I would still like us to be able to expand our tests on the OCaml side though (see discussion with @utdemir here: #195 (review)). We could resolve this issue and open another one, though I think I'd just leave this one open instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing The issue relates to testing
Projects
None yet
Development

No branches or pull requests

2 participants