Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The comment bot is out of date #259

Closed
gkaracha opened this issue Sep 29, 2021 · 1 comment
Closed

The comment bot is out of date #259

gkaracha opened this issue Sep 29, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@gkaracha
Copy link
Contributor

Our comment bot that reports entrypoint size and gas cost differences on open PRs is still invoking nix commands (see .github/workflows/comment.yml) and is thus silently failing, since we switched to docker+earthly. I think we should address this before finishing #213, so that we can evaluate how much do entrypoint sizes and gas costs increase due to generalization.
@gkaracha gkaracha added the bug Something isn't working label Sep 29, 2021
@gkaracha
Copy link
Contributor Author

gkaracha commented Oct 5, 2021

Addressed by #262.

@gkaracha gkaracha closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkaracha